From owner-freebsd-ports@FreeBSD.ORG Wed Jul 16 10:21:00 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 95511BB2 for ; Wed, 16 Jul 2014 10:21:00 +0000 (UTC) Received: from mail-vc0-x22f.google.com (mail-vc0-x22f.google.com [IPv6:2607:f8b0:400c:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 51A212732 for ; Wed, 16 Jul 2014 10:21:00 +0000 (UTC) Received: by mail-vc0-f175.google.com with SMTP id hu12so1179154vcb.20 for ; Wed, 16 Jul 2014 03:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=HRbC3JvaTp/h/gCwbfcu4m+RnR2Hgwu1Qsn5VVgmtBY=; b=0tY6w6bzd1QR3q0CqiDelQ25tymLdLauqhPXoZ0ED02f0T+4Dk4HdU8pDwqb2DTM+t QbyHy317jpL9P4uhw6JWc25MYxgIwf280y3TPWwB6Fo6zlIoBi0fodEA+m55aFU8Gw0V exnDFYdsZkP7Fmc/DLqaKEMG7MuBGwekB/jdEMvsWXcoF2xvX27g0izcJ1CWX8VvJtOL A+q6rvbQuldkCbWFCSfvIlLIcaJMqE5nUGhzhol+IZTl8uSfYhNF0QoOaRO0CyLJcZe0 qNNQmdEBlDZFSKN1gB3K8NDBCQ+0OVbgtV8nLZ8MpCGew1bs2FABdO2D+j1DgOUAa1rR CvlQ== MIME-Version: 1.0 X-Received: by 10.52.118.99 with SMTP id kl3mr23397460vdb.18.1405506059341; Wed, 16 Jul 2014 03:20:59 -0700 (PDT) Received: by 10.220.131.202 with HTTP; Wed, 16 Jul 2014 03:20:59 -0700 (PDT) In-Reply-To: References: <53C3DD16.2040009@FreeBSD.org> Date: Wed, 16 Jul 2014 12:20:59 +0200 Message-ID: Subject: Re: Please commit bug 190843 From: Carlos Jacobo Puga Medina To: freebsd-ports@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2014 10:21:00 -0000 2014-07-14 16:36 GMT+02:00 Carlos Jacobo Puga Medina : > 2014-07-14 15:37 GMT+02:00 Kubilay Kocak : > > On 14/07/2014 11:23 PM, Carlos Jacobo Puga Medina wrote: >> > Added patch to update to 0.7.0 >> > >> > Build logs: >> > >> > https://redports.org/buildarchive/20140714113400-20929/ >> > >> > --CJPM >> > _______________________________________________ >> > freebsd-ports@freebsd.org mailing list >> > http://lists.freebsd.org/mailman/listinfo/freebsd-ports >> > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org >> " >> > >> >> Thanks for your submission Carlos :) >> >> Our issue tracker is the authoritative source of information for change >> requests, so always include all information there before posting on the >> mailing lists. >> >> I also note that OPTIONS_DEFAULT is added in your patch but has no >> value, so you may want to provide a second version of your patch fixing >> that, including the MAINTAINER update, and posting the URL to your >> redports build in a comment, noting that its ready to commit. >> >> > Fixed. > > >> Running portlint (with -AC) flags is also highly recommended (add the >> output in your comment too, even if its clean) >> >> This gives committers confidence++ that your submission is ready to rock >> >> > Thanks for your useful tips, koobs@ > > >> -- >> koobs >> >> >> >> Kind regards, > > --CJPM > I attached a new patch after r362015 was committed. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=190843#c8 --CJPM