From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 04:45:52 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E1A816A4CE for ; Tue, 19 Apr 2005 04:45:52 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3322B43D31 for ; Tue, 19 Apr 2005 04:45:47 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.21] (rat.samsco.home [192.168.254.21]) (authenticated bits=0) by pooker.samsco.org (8.13.1/8.13.1) with ESMTP id j3J4llZY079027; Mon, 18 Apr 2005 22:47:47 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <42648C95.3010102@samsco.org> Date: Mon, 18 Apr 2005 22:44:05 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.7.5) Gecko/20050321 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Conrad J. Sabatier" References: <20050418232455.2d530890@dolphin.local.net> In-Reply-To: <20050418232455.2d530890@dolphin.local.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org cc: freebsd-current@freebsd.org cc: Mathew Kanner Subject: Re: What happened to the "d_maj" member of "struct cdevsw" in CURRENT? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2005 04:45:52 -0000 Conrad J. Sabatier wrote: > I've been trying to help Mat Kanner with his yet-to-be-committed MIDI > patches, and have run into a perplexing problem on amd64 CURRENT. It > seems the "d_maj" member of "struct cdevsw" no longer exists (in > sys/sys/conf.h). This is causing Mat's MIDI patches to fail with: > > > >>===> sound/midi (all) >>cc -O -pipe -march=athlon64 -Wno-error -D_KERNEL -DKLD_MODULE >>-nostdinc -I- -include /usr/obj/usr/src/sys/CUSTOM/opt_global.h -I. >>-I@ -I@/contrib/altq -I@/../include -finline-limit=8000 -fno-common -g >>-fno-omit-frame-pointer -I/usr/obj/usr/src/sys/CUSTOM -mcmodel=kernel >>-mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow >>-msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Wall >>-Wredundant-decls -Wnested-externs -Wstrict-prototypes >>-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual >>-fformat-extensions -std=c99 -c >>/usr/src/sys/modules/sound/midi/../../../dev/sound/midi/midi.c >>/usr/src/sys/modules/sound/midi/../../../dev/sound/midi/midi.c:204: >>error: unknown field `d_maj' specified in initializer > > > When was this member removed, and why? And how to work around this? > > Thanks! > Major numbers are now dynamically assigned. The shims for allowing drivers to choose a static major number were removed a few months ago. There is no work-around for this; just don't include the field anymore in 6-current sources. If there is something that thinks it needs explicit knowledge of major numbers, let me know and we can discuss how to fix it. Scott