From owner-p4-projects@FreeBSD.ORG  Sat Apr  5 16:23:10 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E44DB1065678; Sat,  5 Apr 2008 16:23:09 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A46351065674
	for <perforce@freebsd.org>; Sat,  5 Apr 2008 16:23:09 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 736A78FC1A
	for <perforce@freebsd.org>; Sat,  5 Apr 2008 16:23:09 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m35GN9bp033296
	for <perforce@freebsd.org>; Sat, 5 Apr 2008 16:23:09 GMT
	(envelope-from sam@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m35GN9va033294
	for perforce@freebsd.org; Sat, 5 Apr 2008 16:23:09 GMT
	(envelope-from sam@freebsd.org)
Date: Sat, 5 Apr 2008 16:23:09 GMT
Message-Id: <200804051623.m35GN9va033294@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	sam@freebsd.org using -f
From: Sam Leffler <sam@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 139418 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Apr 2008 16:23:10 -0000

http://perforce.freebsd.org/chv.cgi?CH=139418

Change 139418 by sam@sam_ebb on 2008/04/05 16:22:21

	correct locking on detach

Affected files ...

.. //depot/projects/vap/sys/dev/ral/rt2560.c#25 edit
.. //depot/projects/vap/sys/dev/ral/rt2661.c#22 edit

Differences ...

==== //depot/projects/vap/sys/dev/ral/rt2560.c#25 (text) ====

@@ -360,7 +360,6 @@
 	struct ieee80211com *ic = ifp->if_l2com;
 	
 	rt2560_stop(sc);
-	RAL_LOCK(sc);
 
 	bpfdetach(ifp);
 	ieee80211_ifdetach(ic);

==== //depot/projects/vap/sys/dev/ral/rt2661.c#22 (text) ====

@@ -358,6 +358,7 @@
 	RAL_LOCK(sc);
 	rt2661_stop_locked(sc);
 	callout_stop(&sc->watchdog_ch);
+	RAL_UNLOCK(sc);
 
 	bpfdetach(ifp);
 	ieee80211_ifdetach(ic);