From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Apr 18 15:50:00 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AABC2D09 for ; Fri, 18 Apr 2014 15:50:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6ED141DE4 for ; Fri, 18 Apr 2014 15:50:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s3IFo0Aj095079 for ; Fri, 18 Apr 2014 15:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s3IFo04N095078; Fri, 18 Apr 2014 15:50:00 GMT (envelope-from gnats) Resent-Date: Fri, 18 Apr 2014 15:50:00 GMT Resent-Message-Id: <201404181550.s3IFo04N095078@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Pawel Pekala Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A4382ACC for ; Fri, 18 Apr 2014 15:46:18 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 90BD91DB0 for ; Fri, 18 Apr 2014 15:46:18 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s3IFkISl027335 for ; Fri, 18 Apr 2014 15:46:18 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s3IFkIRG027334; Fri, 18 Apr 2014 15:46:18 GMT (envelope-from nobody) Message-Id: <201404181546.s3IFkIRG027334@cgiserv.freebsd.org> Date: Fri, 18 Apr 2014 15:46:18 GMT From: Pawel Pekala To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/188764: [PATCH] bsd.port.mk makepatch don't create empty patches X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Apr 2014 15:50:00 -0000 >Number: 188764 >Category: ports >Synopsis: [PATCH] bsd.port.mk makepatch don't create empty patches >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Apr 18 15:50:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Pawel Pekala >Release: 10.0 >Organization: >Environment: FreeBSD caprica.slowicza.org 10.0-STABLE FreeBSD 10.0-STABLE #2 r262297: Fri Feb 21 17:42:25 CET 2014 root@caprica.slowicza.org:/usr/obj/usr/src/sys/GENERIC i386 >Description: make makepatch creates empty patch files if file and file.orig are identical When porting sometimes one creates .orig file, does not modify file and forgets about it. When doing make makepatch later empty file is created in files/. Attached patch check if files are identical and aborts patch creation if so. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: bsd.port.mk =================================================================== --- bsd.port.mk (wersja 350505) +++ bsd.port.mk (kopia robocza) @@ -1187,6 +1187,7 @@ for i in `find . -type f -name '*.orig'`; do \ ORG=$$i; \ NEW=$${i%.orig}; \ + cmp -s $${ORG} $${NEW} && continue; \ OUT=${FILESDIR}`${ECHO} $${NEW} | \ ${SED} -e 's|/|__|g' \ -e 's|^\.__|/patch-|'`; \ >Release-Note: >Audit-Trail: >Unformatted: