From owner-freebsd-usb@FreeBSD.ORG Fri Mar 5 12:16:03 2010 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E4469106564A; Fri, 5 Mar 2010 12:16:02 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe05.swip.net [212.247.154.129]) by mx1.freebsd.org (Postfix) with ESMTP id E12B98FC12; Fri, 5 Mar 2010 12:16:01 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=LayyJAJec38A:10 a=MnI1ikcADjEx7bvsp0jZvQ==:17 a=8kQB0OdkAAAA:8 a=6I5d2MoRAAAA:8 a=CxfqWND_AAAA:8 a=ohKGhP3BttdajCcpBR8A:9 a=4YWJtmTpo5oN8uqerrvOmTp5ezYA:4 a=9aOQ2cSd83gA:10 a=SV7veod9ZcQA:10 a=gG3rT_J4tBsA:10 a=rOYtZ52_s44MUy3w:21 a=DiX8HMKZ_-bNuKwZ:21 Received: from [188.126.201.140] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe05.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 1278208635; Fri, 05 Mar 2010 13:15:59 +0100 From: Hans Petter Selasky To: PseudoCylon Date: Fri, 5 Mar 2010 13:14:24 +0100 User-Agent: KMail/1.12.4 (FreeBSD/8.0-STABLE; KDE/4.3.4; amd64; ; ) References: <300673.36369.qm@web51805.mail.re2.yahoo.com> <201003051042.41230.hselasky@c2i.net> <164298.14386.qm@web51805.mail.re2.yahoo.com> In-Reply-To: <164298.14386.qm@web51805.mail.re2.yahoo.com> X-Face: +~\`s("[*|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'(; _IjlA: hGE..Ew, XAQ*o#\/M~SC=S1-f9{EzRfT'|Hhll5Q]ha5Bt-s|oTlKMusi:1e[wJl}kd}GR Z0adGx-x_0zGbZj'e(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L' MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201003051314.24982.hselasky@c2i.net> Cc: freebsd-gnats-submit@freebsd.org, jhanna@pangolin-systems.com, freebsd-usb@freebsd.org, bug-followup@freebsd.org Subject: Re: usb/144423: if_run panic with USB-N13 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2010 12:16:03 -0000 On Friday 05 March 2010 12:40:05 PseudoCylon wrote: > ----- Original Message ---- > > > From: Hans Petter Selasky > > To: PseudoCylon > > Cc: bug-followup@freebsd.org; jhanna@pangolin-systems.com; > > freebsd-usb@freebsd.org; freebsd-gnats-submit@freebsd.org Sent: Fri, > > March 5, 2010 2:42:41 AM > > Subject: Re: usb/144423: if_run panic with USB-N13 > > > > On Friday 05 March 2010 10:31:35 PseudoCylon wrote: > > > >The files seem a little far from the current I am running, I just used > > > >the updates to the usbdevs file and the unlock-lock around the > > > > firmware load in if_run.c. > > > > > > Yes, there are some bits added to support RT3572 chipsets. It would be > > > greately appreciated if you try that file if it's not too mutch > > > trouble. > > > > > > >The ASUS-N13 does work when a child wlan device is created with it, > > > >but if just "ifconfig run0 up" is done there is a page fault. I do > > > >not know if that is expected. This occurs with or without runfw.ko > > > >being loaded beforehand. > > > > > > Yes, "ifconfig run0 up" will cause page fault. The wlanN interface is > > > should be created as an instance of the parent interface and used for > > > actual communication. This is new feature to 8.0 and 9-current. My > > > understanding is that if you create wlan and "ifconfig *wlan0* up", it > > > works, but if you "ifconfig *run0* up", it causes panic. (Of cource > > > without *. I'm trying to enphasize the point in plain text messeage.) > > > That is what should happen. (Actually, result of "ifconfig *run0* up" > > > is undefined.) "run0" should only be used when creating wlan. > > > > > > If "ifconfig *wlan0* ..." is causing problem, please let us know. > > > > What is the backtrace of the panic? > > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2a > _witness_debugger() at _witness_debugger+0x2e > witness_warn() at witness_warn+0x2c2 > trap() at trap+0x2f5 > calltrap() at calltrap+0x8 > --- trap 0xc, rip = 0xffffffff80c5cfd7, rsp = 0xffffff8021f76880, rbp = > 0xffffff8021f768c0 --- run_stop() at run_stop+0x67 > run_init_locked() at run_init_locked+0x33 > run_ioctl() at run_ioctl+0xad > ifioctl() at ifioctl+0xde4 > kern_ioctl() at kern_ioctl+0xc5 > ioctl() at ioctl+0xf0 > syscall() at syscall+0x1af > Xfast_syscall() at Xfast_syscall+0xe1 > --- syscall (54, FreeBSD ELF64, ioctl), rip = 0x800b8286c, rsp = > 0x7fffffffe2f8, rbp = 0x7fffffffe300 --- > > There are number of places refers uninitialized value in run_stop() and > run_init() if vap hasn't created, so it will cause page fault. I can move > those instructions to other places (maybe vap_delete). It won't panic but > device won't work without vap. > Can't you add a NULL pointer check? It should not panic. --HPS