From owner-freebsd-net@FreeBSD.ORG  Sat Dec 14 01:20:19 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 177C0AEE;
 Sat, 14 Dec 2013 01:20:19 +0000 (UTC)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
 by mx1.freebsd.org (Postfix) with ESMTP id CD423128D;
 Sat, 14 Dec 2013 01:20:18 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
 id A47C47300A; Sat, 14 Dec 2013 02:23:08 +0100 (CET)
Date: Sat, 14 Dec 2013 02:23:08 +0100
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: Mike Karels <mike@karels.net>
Subject: Re: IFF_DRV_OACTIVE handling in *_stop() for intel nic drivers ?
Message-ID: <20131214012308.GB82745@onelab2.iet.unipi.it>
References: <CAJ-Vmom8u9mw9h-Eq5EKvcwcpMKjNzdxcwVJLtg_jRfA0DWYxg@mail.gmail.com>
 <201312140008.rBE08tnO062920@mail.karels.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201312140008.rBE08tnO062920@mail.karels.net>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: Jack F Vogel <jfv@freebsd.org>, Adrian Chadd <adrian@freebsd.org>,
 "net@freebsd.org" <net@freebsd.org>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Dec 2013 01:20:19 -0000

On Fri, Dec 13, 2013 at 06:08:55PM -0600, Mike Karels wrote:
> > ... OACTIVE by design is racy. We should just not be using it in newer drivers.
> 
> > I think the correct thing to do is to just plain ignore setting it ever.
> 
> I agree; OACTIVE is totally obsolete for drivers that use if_transmit,
> and not particularly useful for other drivers.  It might be time to remove
> OACTIVE, or define it to be 0.  (And I added the original IFF_OACTIVE).

ok thanks for the clarification
luigi