From owner-cvs-ports@FreeBSD.ORG Mon Jan 24 16:22:25 2005 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 117D516A4CE; Mon, 24 Jan 2005 16:22:25 +0000 (GMT) Received: from gw.celabo.org (gw.celabo.org [208.42.49.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id 718DE43D1F; Mon, 24 Jan 2005 16:22:24 +0000 (GMT) (envelope-from nectar@celabo.org) Received: from lum.celabo.org (lum.celabo.org [10.0.1.107]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "lum.celabo.org", Issuer "celabo.org CA" (verified OK)) by gw.celabo.org (Postfix) with ESMTP id F2BAB3E2C42; Mon, 24 Jan 2005 10:22:23 -0600 (CST) Received: by lum.celabo.org (Postfix, from userid 1001) id 3FE4B593BC6; Mon, 24 Jan 2005 10:22:23 -0600 (CST) Date: Mon, 24 Jan 2005 10:22:23 -0600 From: "Jacques A. Vidrine" To: Palle Girgensohn Message-ID: <20050124162223.GM3960@lum.celabo.org> Mail-Followup-To: "Jacques A. Vidrine" , Palle Girgensohn , Mathieu Arnold , Sean Chittenden , ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org References: <20050123100627.35E4716A501@hub.freebsd.org> <3FB436057021D7C93416454A@cc-147.int.t-online.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://www.celabo.org/ User-Agent: Mutt/1.5.6i cc: Mathieu Arnold cc: Sean Chittenden cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports UPDATING ports/databases/postgresql-devel Makefile distinfo pkg-plist ports/databases/postgresql80-server Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2005 16:22:25 -0000 On Mon, Jan 24, 2005 at 03:43:40PM +0100, Palle Girgensohn wrote: > > > --On söndag, januari 23, 2005 11.22.50 +0100 Mathieu Arnold > wrote: > > >+-le 23/01/2005 10:06 +0000, Sean Chittenden écrivait : > >| seanc 2005-01-23 10:06:21 UTC > >| Port epoch bumped because 8.0.rc* is greater than 8.0.0. > > > >Note quite sure about that : > >$ pkg_version -t 8.0.rc5.2005.01.16 8.0.0 > >< > > Uh, 4.10 differs from 5.3 here: > > FreeBSD 4.10$ pkg_version -t 8.0.0rc5 8.0.0 > > > FreeBSD 4.10$ pkg_version -t 8.0rc5.2005.01.16 8.0.0 > > > > FreeBSD 5.3$ pkg_version -t 8.0.0rc5 8.0.0 > < > FreeBSD 5.3$ pkg_version -t 8.0rc5.2005.01.16 8.0.0 > < This is partially pilot error. Note that "8.0.rc5" and "8.0rc5" are really completely different versions. Unfortunately, this was changed by revision 1.5 of src/usr.sbin/pkg_install/lib/version.c: several strings including "rc" are now handled specially in direct contradiction of our documented Package Naming Conventions. I think the change was wrong and insufficiently reviewed, but it is too late now. Of course, ports that actually correctly follow the Porter's Handbook never be named such that this makes a difference. In other words, the Porter's Handbook recommends against names such as "8.0rc" or "8.0beta" in favor of "8.0.r" and "8.0.b". > portupgrade has it own algorithm. In conflict with pkg_version-5.3, > it considers 8.0.0rc or even 8.0.0beta to be greater than 8.0.0. That's because portupgrade does the right thing and follows the Porter's Handbook when it comes to version numbers. > pkg_version-5.3 does the right thing, and to me it looks like the > portupgrade's algorithm for versioning is overly simple (I've never > used ruby though, perhaps it has some fancy operator overload > stuff?): No, see above. [...] > I haven't checked if this is fixed in 4.11, but since it is not even out, > bumping port epoch is unfortunately necessary. :( It was not necessary--- you just made typos in your tests ("8.0.rc5", not "8.0rc5"). However, it is now necessary that it stays. Cheers, -- Jacques A Vidrine / NTT/Verio nectar@celabo.org / jvidrine@verio.net / nectar@FreeBSD.org