From owner-freebsd-hackers Wed Oct 30 12:42:20 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA27744 for hackers-outgoing; Wed, 30 Oct 1996 12:42:20 -0800 (PST) Received: from gvr.win.tue.nl (gvr.win.tue.nl [131.155.210.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id MAA27735 for ; Wed, 30 Oct 1996 12:42:03 -0800 (PST) Received: (from guido@localhost) by gvr.win.tue.nl (8.8.2/8.8.2) id VAA09887; Wed, 30 Oct 1996 21:40:00 +0100 (MET) From: Guido van Rooij Message-Id: <199610302040.VAA09887@gvr.win.tue.nl> Subject: Re: rlogind user name restrictions In-Reply-To: <199610302035.OAA03828@starfire.mn.org> from "john@starfire.mn.org" at "Oct 30, 96 02:35:19 pm" To: john@starfire.mn.org Date: Wed, 30 Oct 1996 21:39:59 +0100 (MET) Cc: hackers@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL28 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk john@starfire.mn.org wrote: > > > --- /usr/src/libexec/rlogind/rlogind.c Sun Jun 23 15:07:44 1996 > > +++ /tmp/rlogind.c Wed Oct 30 20:55:23 1996 > > @@ -293,7 +293,7 @@ > > if (f > 2) /* f should always be 0, but... */ > > (void) close(f); > > setup_term(0); > > - if (strchr(lusername, '-')) { > > + if (lusername == '-') { > ^^^^^^^^^ > Shouldn't this be "*lusername" or "lusername[0]"????????? Of course that should be *lusername. That's the problem when you havent setup cvsup and you do things by head ;-() > > Even doing this, has it been checked that there are no throw-away > characters that login might skip over that would make the corrected > test ineffectual? I'm not that totally familiar with the internal > operation of "getopt" that I could speak authoritatively to this > issue, which is why I didn't submit my diffs in the first place. > That was what I meant by "BAD THINGS". no problems there. -Guido