From owner-freebsd-current Tue Dec 19 15: 8:17 2000 From owner-freebsd-current@FreeBSD.ORG Tue Dec 19 15:08:14 2000 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from clmboh1-smtp3.columbus.rr.com (unknown [65.24.0.112]) by hub.freebsd.org (Postfix) with ESMTP id 6D02737B400; Tue, 19 Dec 2000 15:08:13 -0800 (PST) Received: from zoomer (dzerkel@dhcp065-024-166-103.columbus.rr.com [65.24.166.103]) by clmboh1-smtp3.columbus.rr.com (8.9.3/8.9.3) with SMTP id SAA29297; Tue, 19 Dec 2000 18:05:56 -0500 (EST) From: "Danny J. Zerkel" Organization: Zerkular Software To: Mitsuru IWASAKI , roam@orbitel.bg Subject: Re: dev/acpica/acpi.c - minor patch for cleaner poweroff Date: Tue, 19 Dec 2000 18:07:59 -0500 X-Mailer: KMail [version 1.1.99] Content-Type: text/plain; charset="us-ascii" Cc: msmith@FreeBSD.ORG, current@FreeBSD.ORG References: <20001218165732.A5418@ringworld.oblivion.bg> <20001220003605D.iwasaki@jp.FreeBSD.org> In-Reply-To: <20001220003605D.iwasaki@jp.FreeBSD.org> MIME-Version: 1.0 Message-Id: <00121918075900.00425@zoomer> Content-Transfer-Encoding: 8bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG This patch works for me on a P2B-DS, previously I had to power off by hand. Thanks! Danny On Tuesday 19 December 2000 10:36, Mitsuru IWASAKI wrote: > Hi, > > > I think you're the main maintainer of the ACPICA codebase (and yes, I > > know that parts of it is imported from Intel). Attached is a trivial > > patch which makes for cleaner testing for RB_POWEROFF in > > acpi_shutdown_final() - I've had various kernel/userland routines invoke > > reboot sequences where the howto had more bits set than RB_POWEROFF, e.g. > > RB_NOSYNC. With this patch, shutdown -p works for me :) > > Thanks, this patch looks good. I'll fix this soon. > I'm sure mike will agree on it :-) > > > Thanks for all the work on ACPICA :) > > > > G'luck, > > Peter > > > > PS. Please CC: me in replies as I'm not on -current. > > > > -- > > If I had finished this sentence, > > > > Index: acpi.c > > =================================================================== > > RCS file: /home/ncvs/src/sys/dev/acpica/acpi.c,v > > retrieving revision 1.7 > > diff -u -r1.7 acpi.c > > --- acpi.c 2000/12/12 14:20:27 1.7 > > +++ acpi.c 2000/12/18 14:55:43 > > @@ -657,7 +657,7 @@ > > { > > ACPI_STATUS status; > > > > - if (howto == RB_POWEROFF) { > > + if (howto & RB_POWEROFF) { > > printf("Power system off using ACPI...\n"); > > if ((status = AcpiSetSystemSleepState(ACPI_STATE_S5)) != AE_OK) { > > printf("ACPI power-off failed - %s\n", acpi_strerror(status)); > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > with "unsubscribe freebsd-current" in the body of the message > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message -- ------------------ dzerkel@columbus.rr.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message