From owner-freebsd-net@FreeBSD.ORG  Thu Jan 14 15:20:03 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5D451106566B
	for <freebsd-net@hub.freebsd.org>; Thu, 14 Jan 2010 15:20:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 4B7BF8FC08
	for <freebsd-net@hub.freebsd.org>; Thu, 14 Jan 2010 15:20:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0EFK3MF022258
	for <freebsd-net@freefall.freebsd.org>; Thu, 14 Jan 2010 15:20:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0EFK2B1022257;
	Thu, 14 Jan 2010 15:20:03 GMT (envelope-from gnats)
Date: Thu, 14 Jan 2010 15:20:03 GMT
Message-Id: <201001141520.o0EFK2B1022257@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Bernhard Schmidt <bschmidt@techwires.net>
Cc: 
Subject: Re: kern/142018: [iwi] [patch] Possibly wrong interpretation of
	beacon-&gt; number in if_iwi.c
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Bernhard Schmidt <bschmidt@techwires.net>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2010 15:20:03 -0000

The following reply was made to PR kern/142018; it has been noted by GNATS.

From: Bernhard Schmidt <bschmidt@techwires.net>
To: bug-followup@freebsd.org, Andre.Albsmeier@siemens.com
Cc:  
Subject: Re: kern/142018: [iwi] [patch] Possibly wrong interpretation of beacon-&gt;number in if_iwi.c
Date: Thu, 14 Jan 2010 16:10:28 +0100

 Hi,
 
 It might be simple endianess related issue, does this patch make any 
 difference?
 
 Index: if_iwi.c
 ===================================================================
 --- sys/dev/iwi/if_iwi.c	(revision 202285)
 +++ sys/dev/iwi/if_iwi.c	(working copy)
 @@ -1499,9 +1499,9 @@ iwi_notification_intr(struct iwi_softc *sc, struct
  		beacon = (struct iwi_notif_beacon_state *)(notif + 1);
  
  		DPRINTFN(5, ("Beacon state (%u, %u)\n",
 -		    beacon->state, le32toh(beacon->number)));
 +		    le32toh(beacon->state), le32toh(beacon->number)));
  
 -		if (beacon->state == IWI_BEACON_MISS) {
 +		if (le32toh(beacon->state) == IWI_BEACON_MISS) {
  			/*
  			 * The firmware notifies us of every beacon miss
  			 * so we need to track the count against the
 
 -- 
 Bernhard