From owner-cvs-all@FreeBSD.ORG Tue Jan 27 02:53:49 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D24A616A4CF for ; Tue, 27 Jan 2004 02:53:49 -0800 (PST) Received: from gandalf.online.bg (gandalf.online.bg [217.75.128.9]) by mx1.FreeBSD.org (Postfix) with SMTP id 5038F43D5A for ; Tue, 27 Jan 2004 02:53:26 -0800 (PST) (envelope-from roam@ringlet.net) Received: (qmail 19040 invoked from network); 27 Jan 2004 10:50:47 -0000 Received: from office.sbnd.net (HELO straylight.m.ringlet.net) (217.75.140.130) by gandalf.online.bg with SMTP; 27 Jan 2004 10:50:46 -0000 Received: (qmail 97875 invoked by uid 1000); 27 Jan 2004 10:53:34 -0000 Date: Tue, 27 Jan 2004 12:53:34 +0200 From: Peter Pentchev To: John Baldwin Message-ID: <20040127105334.GI823@straylight.m.ringlet.net> Mail-Followup-To: John Baldwin , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <20040126200039.0F1F516A4D2@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Fba/0zbH8Xs+Fj9o" Content-Disposition: inline In-Reply-To: <20040126200039.0F1F516A4D2@hub.freebsd.org> User-Agent: Mutt/1.5.5.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c acpivar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2004 10:53:49 -0000 --Fba/0zbH8Xs+Fj9o Content-Type: text/plain; charset=windows-1251 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 26, 2004 at 12:00:39PM -0800, John Baldwin wrote: > To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, > cvs-all@FreeBSD.org > Message-ID: <200401261929.i0QJT45s012253@repoman.freebsd.org> >=20 > jhb 2004/01/26 11:29:04 PST >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/acpica acpi.c acpivar.h=20 > Log: > Move the code to initialize ACPI-CA into a separate acpi_Startup() func= tion > that other modules can call to initialize ACPI-CA before the new-bus pr= obe > and change acpi_identify() to call it. > =20 > Reviewed by: njl This seems to also need the attached patch (trivial: add an ACPI_FUNCTION_TRACE() to the acpi_Startup() routine) to build LINT. G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@sbnd.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 This sentence contains exactly threee erors. Index: src/sys/dev/acpica/acpi.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/dev/acpica/acpi.c,v retrieving revision 1.114 diff -u -r1.114 acpi.c --- src/sys/dev/acpica/acpi.c 26 Jan 2004 19:29:03 -0000 1.114 +++ src/sys/dev/acpica/acpi.c 27 Jan 2004 09:02:06 -0000 @@ -204,6 +204,8 @@ #endif static int error, started =3D 0; =20 + ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); + if (started) return_VALUE(error); started =3D 1; --Fba/0zbH8Xs+Fj9o Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAFkMu7Ri2jRYZRVMRAtWPAKCSEnZ5DAHujZpIDLEOR6ev2hVg/gCgxgVA 7E/yuls0cBmh3CwQKKAhgiY= =7Gda -----END PGP SIGNATURE----- --Fba/0zbH8Xs+Fj9o--