From owner-svn-src-all@freebsd.org Sat Dec 12 07:56:22 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45F15A140D2; Sat, 12 Dec 2015 07:56:22 +0000 (UTC) (envelope-from cochard@gmail.com) Received: from mail-lb0-x22f.google.com (mail-lb0-x22f.google.com [IPv6:2a00:1450:4010:c04::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ACFED1630; Sat, 12 Dec 2015 07:56:21 +0000 (UTC) (envelope-from cochard@gmail.com) Received: by lbpu9 with SMTP id u9so75574941lbp.2; Fri, 11 Dec 2015 23:56:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=FtQsa1erTWb3ujBw7hko3DPBeso4Tyxrna6KfzQHQwo=; b=ILCtCprJ0xVM5ZQKPDvmgcaT/AvUulkGPaiu8jqBmqL7wj1xIbtqpM3abMvx98e2/b s2K+6gY7h+o/+JNQB2lLrKNZe+qz8DhdCzg3gCf4FhEFIgdtPJdodp1tYLLWMeVDNpCE VtgO7Z513Lh0GtQ5sNT7dSTZxOPTUJo090m3zxcqiMWi8IvERSPrusEBVJbYARk1T9Hr g2islazIaH7OcJzTro+kg3WHg+qI52SqrRsORrp3K+/VrC3NatowjWQsQlAVWKlXN4ma UXQkqrU8bO7HvsS0EHRGSqELjdxGRoH+yD0SZul3VbudyNd/WxktFyhqttwe7fjrorEt iuqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cochard-me.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=FtQsa1erTWb3ujBw7hko3DPBeso4Tyxrna6KfzQHQwo=; b=SwFWvOsa2WHTVc2Gbh6CtpRdNjxq3naESXTrjLF7UiihIVH9SoqwZIKgQXpIwceCum GxcHSSOFz3NGw3QFWDo7wAkr5/MuKVrgpV8WgOGTiGKFE9ivzhN6mFcci3E8+7huzxby TQ0cGJqBEgSwHIsWyA/afH4clz2YtdqfJk4png/nk0mU5oyeU4LisRaxNEJSUP3my6Xj JcqWMIh+huOMclRtm1YB/jrFPyEYY+IRC4SaWu/MZuStRcKowvI9m+yDCyQtr6AupSa5 059oB1roPIkwOqEAE0gnz7JWCsEZvN+7VaRxT+w3JbR0KFGVH5tUNlk/dnJYmpffSgZG S+Rg== X-Received: by 10.112.172.231 with SMTP id bf7mr9323321lbc.5.1449906979054; Fri, 11 Dec 2015 23:56:19 -0800 (PST) MIME-Version: 1.0 Sender: cochard@gmail.com Received: by 10.25.197.195 with HTTP; Fri, 11 Dec 2015 23:55:59 -0800 (PST) In-Reply-To: <201512070402.tB742V3Z081964@repo.freebsd.org> References: <201512070402.tB742V3Z081964@repo.freebsd.org> From: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= Date: Sat, 12 Dec 2015 08:55:59 +0100 X-Google-Sender-Auth: 2GRZRjHiu1gFe1Ch_JsSuPf9jA4 Message-ID: Subject: Re: svn commit: r291913 - head/tools/tools/nanobsd To: Warner Losh Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Dec 2015 07:56:22 -0000 On Mon, Dec 7, 2015 at 5:02 AM, Warner Losh wrote: > Author: imp > Date: Mon Dec 7 04:02:31 2015 > New Revision: 291913 > URL: https://svnweb.freebsd.org/changeset/base/291913 > > Log: > Generally use shorter, more idiomatic sh expressions in a bunch of > places. > > Modified: > head/tools/tools/nanobsd/defaults.sh (contents, props changed) > =E2=80=8BHi, I beleive there is a tipo here : =E2=80=8B > > Modified: head/tools/tools/nanobsd/defaults.sh > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/tools/tools/nanobsd/defaults.sh Mon Dec 7 04:02:19 2015 > (r291912) > +++ head/tools/tools/nanobsd/defaults.sh Mon Dec 7 04:02:31 2015 > (r291913) > > ####################################################################### > @@ -949,21 +949,21 @@ export_var ( ) { # Don't wawnt a subshe > # Call this function to set defaults _after_ parsing options. > # dont want a subshell otherwise variable setting is thrown away. > set_defaults_and_export ( ) { > - test -n "${NANO_OBJ}" || NANO_OBJ=3D/usr/obj/nanobsd.${NANO_NAME} > - test -n "${MAKEOBJDIRPREFIX}" || MAKEOBJDIRPREFIX=3D${NANO_OBJ} > - test -n "${NANO_DISKIMGDIR}" || NANO_DISKIMGDIR=3D${NANO_OBJ} > + : ${NANO_OBJ:=3D/usr/obj/nanobsd.${NANO_NAME}} > + : ${MAKEOBJDIRPREFIX:=3D${NANO_OBJ}} > + : ${NANO_DISKIMGDIR=3D:${NANO_OBJ}} > NANO_WORLDDIR=3D${NANO_OBJ}/_.w > NANO_MAKE_CONF_BUILD=3D${MAKEOBJDIRPREFIX}/make.conf.build > NANO_MAKE_CONF_INSTALL=3D${NANO_OBJ}/make.conf.install > > =E2=80=8BNotice the line: : ${NANO_DISKIMGDIR=3D:${NANO_OBJ}} I beleive the good one is: : ${NANO_DISKIMGDIR=3D${NANO_OBJ}} =E2=80=8B(without the ':' before ${NANO_OBJ}} Because with the ':' variable NANO_DISKIMGDIR includes the ':' in front of its values, and dd didn't like it: + IMG=3D:/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img + MNT=3D/usr/obj/BSDRPcur.amd64/_.mnt + mkdir -p /usr/obj/BSDRPcur.amd64/_.mnt + [ file '=3D' swap ] + echo 'Creating md backing file...' Creating md backing file... + rm -f :/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img + echo 'NANO RM -f :/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img= ' NANO RM -f :/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img + uname -r + command rm -x -f :/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img + dd 'if=3D/dev/zero' 'of=3D:/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img' 'seek=3D1000000' 'count=3D0' dd: :/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img: No such file or directory Regards, Olivier