From owner-freebsd-ipfw@FreeBSD.ORG  Wed Apr 24 18:40:01 2013
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: freebsd-ipfw@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 3FFC7DAB
 for <freebsd-ipfw@smarthost.ysv.freebsd.org>;
 Wed, 24 Apr 2013 18:40:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 329B115E2
 for <freebsd-ipfw@smarthost.ysv.freebsd.org>;
 Wed, 24 Apr 2013 18:40:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3OIe19p069711
 for <freebsd-ipfw@freefall.freebsd.org>; Wed, 24 Apr 2013 18:40:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3OIe1AR069710;
 Wed, 24 Apr 2013 18:40:01 GMT (envelope-from gnats)
Date: Wed, 24 Apr 2013 18:40:01 GMT
Message-Id: <201304241840.r3OIe1AR069710@freefall.freebsd.org>
To: freebsd-ipfw@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: kern/157796: commit references a PR
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ipfw>,
 <mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
 <mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Apr 2013 18:40:01 -0000

The following reply was made to PR kern/157796; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/157796: commit references a PR
Date: Wed, 24 Apr 2013 18:30:40 +0000 (UTC)

 Author: rrs
 Date: Wed Apr 24 18:30:32 2013
 New Revision: 249848
 URL: http://svnweb.freebsd.org/changeset/base/249848
 
 Log:
   This fixes the issue with the "randomly changing" default
   route. What it was is there are two places in ip_output.c
   where we do a goto again. One place was fine, it
   copies out the new address and then resets dst = ro->rt_dst;
   But the other place does *not* do that, which means earlier
   when we found the gateway, we have dst pointing there
   aka dst = ro->rt_gateway is done.. then we do a
   goto again.. bam now we clobber the default route.
   
   The fix is just to move the again so we are always
   doing dst = &ro->rt_dst; in the again loop.
   
   PR:	 174749,157796
   MFC after:	1 week
 
 Modified:
   head/sys/netinet/ip_output.c
 
 Modified: head/sys/netinet/ip_output.c
 ==============================================================================
 --- head/sys/netinet/ip_output.c	Wed Apr 24 18:00:28 2013	(r249847)
 +++ head/sys/netinet/ip_output.c	Wed Apr 24 18:30:32 2013	(r249848)
 @@ -196,8 +196,8 @@ ip_output(struct mbuf *m, struct mbuf *o
  		hlen = ip->ip_hl << 2;
  	}
  
 -	dst = (struct sockaddr_in *)&ro->ro_dst;
  again:
 +	dst = (struct sockaddr_in *)&ro->ro_dst;
  	ia = NULL;
  	/*
  	 * If there is a cached route,
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"