From owner-cvs-all Sat Sep 7 0:38:27 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 79B3F37B400; Sat, 7 Sep 2002 00:38:24 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 38B8943E65; Sat, 7 Sep 2002 00:38:23 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id RAA22084; Sat, 7 Sep 2002 17:38:21 +1000 Date: Sat, 7 Sep 2002 17:45:53 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Maxim Sobolev Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/net if_gre.h In-Reply-To: <200209062158.g86Lwvnx040346@freefall.freebsd.org> Message-ID: <20020907172938.Y18391-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 6 Sep 2002, Maxim Sobolev wrote: > sobomax 2002/09/06 14:58:57 PDT > > Modified files: > sys/net if_gre.h > Log: > Include to unbreak kdump. I don't know why does kdump > includes if_gre.h at all, but it does, without including ip.h before > that. > > Poked by: peter > Pointy hat to: kdump(1) > > Revision Changes Path > 1.3 +4 -0 src/sys/net/if_gre.h This makes things worse. It doesn't affect kdump, since the include is conditional on the kernel option INET. If the include were unconditional, then it would cause even more namespace pollution to be exported to userland. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message