From owner-freebsd-ports-bugs@FreeBSD.ORG  Sun Sep  5 22:10:02 2010
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EE51B10656A6
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sun,  5 Sep 2010 22:10:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D9CAF8FC22
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sun,  5 Sep 2010 22:10:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o85MA2wo069658
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Sun, 5 Sep 2010 22:10:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o85MA2dI069657;
	Sun, 5 Sep 2010 22:10:02 GMT (envelope-from gnats)
Date: Sun, 5 Sep 2010 22:10:02 GMT
Message-Id: <201009052210.o85MA2dI069657@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Alex Samorukov <samm@os2.kiev.ua>
Cc: 
Subject: Re: ports/150235: sysutils/smartmontools build system bug
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Alex Samorukov <samm@os2.kiev.ua>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Sep 2010 22:10:03 -0000

The following reply was made to PR ports/150235; it has been noted by GNATS.

From: Alex Samorukov <samm@os2.kiev.ua>
To: Doug Barton <dougb@FreeBSD.org>
Cc: Garrett Wollman <wollman@FreeBSD.org>, bug-followup@FreeBSD.org, 
 developers@FreeBSD.org
Subject: Re: ports/150235: sysutils/smartmontools build system bug
Date: Mon, 06 Sep 2010 00:06:54 +0200

 On 09/05/2010 11:44 PM, Doug Barton wrote:
 > On 09/05/2010 12:28 PM, Alex Samorukov wrote:
 >> Your proposed patch will break smartmontools functionality - thats why
 >> i`m not able to accept it.
 >
 > It's not at all clear to me why developers@ is cc'ed on these 
 > messages, but since we are ...
 >
 > Alex,
 >
 > Can you please explain why the change Garrett is suggesting will break 
 > anything? According to his PR all the headers that smartmontools needs 
 > are included in /usr/include. Is that not the case?
 It is not the case. cciss.cpp from the sources uses dev/ciss/cissio.h to 
 work with cciss devices on FreeBSD. configure script checks if this file 
 is exists on the compile time, and if its not - does not compile cciss 
 support in the smartmontools.
 If user will try to use cciss driver in this case - smartmontools will 
 display an error:
 
 "CCISS support is not available in this build of smartmontools,\n"  
 "/usr/src/sys/dev/ciss/cissio.h was not available at build time.\n\n");
 
 
 >
 > What you've been told (that we prefer not to have userland tools 
 > include /usr/src directly) is accurate, so the burden of proof is on 
 > you to explain why it's necessary in this case. The fact that other 
 > ports may or may not do this is not relevant here.
 >
 I hope my explanation is clear.