From owner-cvs-ports Tue Mar 31 18:24:49 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id SAA19364 for cvs-ports-outgoing; Tue, 31 Mar 1998 18:24:49 -0800 (PST) (envelope-from owner-cvs-ports) Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [128.120.56.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA19181; Tue, 31 Mar 1998 18:24:38 -0800 (PST) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by relay.nuxi.com (8.8.7/8.6.12) id CAA06268; Wed, 1 Apr 1998 02:24:36 GMT Message-ID: <19980331182436.07294@nuxi.com> Date: Tue, 31 Mar 1998 18:24:36 -0800 From: "David E. O'Brien" To: Brian Handy Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-ports@FreeBSD.ORG Subject: Re: cvs commit: ports/print/mgv Makefile ports/print/mgv/patches patch-ac Reply-To: obrien@NUXI.com References: <19980331122246.50218@nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.88 In-Reply-To: ; from Brian Handy on Tue, Mar 31, 1998 at 06:07:39PM -0800 X-Warning: Mutt Bites! X-Operating-System: FreeBSD 2.2.5-STABLE Organization: The NUXI *BSD group X-PGP-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Keyid: 34F9F9D5 Sender: owner-cvs-ports@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > >Yes I did. But when using the 3.0 Makefile on -STABLE, the about box > >claims it was built on a 3.0 system which is *obviously* wrong. > > I'll try again. Did you break compiling on -CURRENT for a lousy "about" > box??? Why is it broken on -CURRENT? After patching the only difference is the text in the "about box". > Does this seem like a reasonable exchange to you? Certainly, I don't see the issue with it. Especially since I had to go clean up -lXm to ${MOTIFLIB} anyway. > >> Unless you have compelling evidence otherwise, please back the makefile > >> selection out. > > > >1. Ports track -STABLE > >2. when I looked for a MAINTIER in the Makefile, I didn't see one. So I > > felt justified in making the change. > > ABOUT boxes don't have to track -STABLE :-) True, but it is misleading. If I downloaded the package and saw the "about box" say "3.0", I would have figured I typed "package-current" again when I wanted "packages-stable". Those running -CURRENT shouldn't expect perfection from the ports system. We try, but don't guarantee it. The real fix would be to link *both* makefiles to ${WRKSRC} and set ${MAKEFILE} depending on the value of sysctl -n kern.osreldate | sed -e '/.....$$/s///' -- -- David (obrien@NUXI.ucdavis.edu -or- obrien@FreeBSD.org)