From owner-freebsd-security@FreeBSD.ORG  Sat Sep 22 09:18:49 2012
Return-Path: <owner-freebsd-security@FreeBSD.ORG>
Delivered-To: freebsd-security@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BCA28106566C
	for <freebsd-security@freebsd.org>;
	Sat, 22 Sep 2012 09:18:49 +0000 (UTC)
	(envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72])
	by mx1.freebsd.org (Postfix) with ESMTP id 8024C8FC08
	for <freebsd-security@freebsd.org>;
	Sat, 22 Sep 2012 09:18:49 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
	by mail.dawidek.net (Postfix) with ESMTPSA id C04B5CCC;
	Sat, 22 Sep 2012 11:17:51 +0200 (CEST)
Date: Sat, 22 Sep 2012 11:19:08 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: RW <rwmaillists@googlemail.com>
Message-ID: <20120922091908.GB1454@garage.freebsd.pl>
References: <20120918211422.GA1400@garage.freebsd.pl>
	<20120919192836.3a60cdfd@gumby.homeunix.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="FkmkrVfFsRoUs1wW"
Content-Disposition: inline
In-Reply-To: <20120919192836.3a60cdfd@gumby.homeunix.com>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-security@freebsd.org
Subject: Re: Collecting entropy from device_attach() times.
X-BeenThere: freebsd-security@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Security issues \[members-only posting\]"
	<freebsd-security.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-security>, 
	<mailto:freebsd-security-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-security>
List-Post: <mailto:freebsd-security@freebsd.org>
List-Help: <mailto:freebsd-security-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-security>, 
	<mailto:freebsd-security-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Sep 2012 09:18:49 -0000


--FkmkrVfFsRoUs1wW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 19, 2012 at 07:28:36PM +0100, RW wrote:
> On Tue, 18 Sep 2012 23:14:22 +0200
> Pawel Jakub Dawidek wrote:
>=20
> > Hi.
> >=20
>=20
> > The patch is here:
> >=20
> > 	http://people.freebsd.org/~pjd/patches/harvest_device_attach.patch
> >=20
> > Comments?
> >=20
>=20
> +	attachtime =3D get_cyclecount() - attachtime;
>=20
> the above line is redundant since random_harvest() already contains a
> call to get_cyclecount().

Agreed, although in more recent patch I need total time, so I can
calculate how many bits it has, so I can estimate how much entropy there
is.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--FkmkrVfFsRoUs1wW
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlBdgowACgkQForvXbEpPzT6LwCfQnX0XeMrJq57lGnxeFats/yo
I6gAoOgyrhyRS4jBmCbwjAl9Ma6YzJFR
=jesV
-----END PGP SIGNATURE-----

--FkmkrVfFsRoUs1wW--