From owner-freebsd-ports Fri Jan 10 15:10: 7 2003 Delivered-To: freebsd-ports@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C4AB37B405 for ; Fri, 10 Jan 2003 15:10:05 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1448243EB2 for ; Fri, 10 Jan 2003 15:10:05 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h0ANA4NS057985 for ; Fri, 10 Jan 2003 15:10:04 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h0ANA4Bt057984; Fri, 10 Jan 2003 15:10:04 -0800 (PST) Date: Fri, 10 Jan 2003 15:10:04 -0800 (PST) Message-Id: <200301102310.h0ANA4Bt057984@freefall.freebsd.org> To: freebsd-ports@FreeBSD.org Cc: From: Keith Jones Subject: Re: ports/46944: Update port: emulators/stella Reply-To: Keith Jones Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR ports/46944; it has been noted by GNATS. From: Keith Jones To: KATO Tsuguru Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/46944: Update port: emulators/stella Date: Fri, 10 Jan 2003 23:06:32 +0000 Hi Kato, I'm a bit of a port newbie, so apologies if I have got this completely wrong, but I just noticed a couple of things with the Makefile diff. You appear to have inadvertently blown away the DOCSDIR definition in the Makefile, and it's still used. Is this right? Also, is there a reason for using ${PORTNAME}-${PORTREVISION} instead of ${PKGNAME}? Finally, DATADIR appears to be used but not defined? Regards Keith To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message