From owner-cvs-all@FreeBSD.ORG Wed Aug 31 14:03:38 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 080D016A41F; Wed, 31 Aug 2005 14:03:38 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 583F343D46; Wed, 31 Aug 2005 14:03:37 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 86A6E52C19; Wed, 31 Aug 2005 16:03:35 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 6624952BC5; Wed, 31 Aug 2005 16:03:28 +0200 (CEST) Date: Wed, 31 Aug 2005 16:03:01 +0200 From: Pawel Jakub Dawidek To: Gleb Smirnoff Message-ID: <20050831140301.GB791@garage.freebsd.pl> References: <200508311356.j7VDuG2v098047@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/NkBOFFp2J2Af1nK" Content-Disposition: inline In-Reply-To: <200508311356.j7VDuG2v098047@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng devel (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2005 14:03:38 -0000 --/NkBOFFp2J2Af1nK Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 31, 2005 at 01:56:15PM +0000, Gleb Smirnoff wrote: +> glebius 2005-08-31 13:56:15 UTC +>=20 +> FreeBSD src repository +>=20 +> Modified files: (Branch: RELENG_6) +> sys/netinet tcp_syncache.c=20 +> Log: +> MFC 1.76: +> - Refuse hashsize of 0, since it is invalid. [...] +> - if (!powerof2(tcp_syncache.hashsize)) { +> + if (!powerof2(tcp_syncache.hashsize) || tcp_syncache.hashsize =3D=3D 0= ) { I ran into this as well. The problem here is powerof2() macro and the macro should be fixed: 0 is not a power of 2. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --/NkBOFFp2J2Af1nK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDFbiVForvXbEpPzQRAu7wAKDOsH0o7OlHmpUwdQwVg+eiDIdcLwCg0rqw u86A1ThbGW38r2mu2Qio/fw= =eKwV -----END PGP SIGNATURE----- --/NkBOFFp2J2Af1nK--