From owner-svn-src-all@FreeBSD.ORG Fri Jan 17 06:33:24 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 26D3B336; Fri, 17 Jan 2014 06:33:24 +0000 (UTC) Received: from mail-ea0-x22f.google.com (mail-ea0-x22f.google.com [IPv6:2a00:1450:4013:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3AC0E1331; Fri, 17 Jan 2014 06:33:23 +0000 (UTC) Received: by mail-ea0-f175.google.com with SMTP id z10so1517498ead.6 for ; Thu, 16 Jan 2014 22:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=MeP6NWHF8d5MAc8bAfV7GJB1uyDf352YSmsQIaWiAv8=; b=evHfPPNHMvV3eJW6IFy07iwm14/ocNMhdettz2iJD2+m7F/7mvznLZKIizWYSWXbCm gf/hraoGM0MCUYVfh+QNM1ml9nQVFJiCd1dTns//JY/oC009MDsM2mtD8iHpr/KgwZwJ vAuNp+xAuXhSgd5AQHraYYvj+I868k1skD8LnUSAAETqHQbB6+V5Ww6SQ0Iw1SFWR7/i OB7CoFO8ZEJXAY7d1y15lI2059pC9waUC2e2tSIKAa9rEsbAQNsJOfDfbODLchkIUZyx pO09G2edgC3Dlu+aEUALqRXlRD5cGlv7ACgXwetR3KLrYsCyjmzwPnqI88cyJlYx/Iqn O4bw== MIME-Version: 1.0 X-Received: by 10.14.6.5 with SMTP id 5mr170605eem.51.1389940401294; Thu, 16 Jan 2014 22:33:21 -0800 (PST) Sender: hiren.panchasara@gmail.com Received: by 10.14.2.66 with HTTP; Thu, 16 Jan 2014 22:33:21 -0800 (PST) In-Reply-To: <20140117044254.GB56239@onelab2.iet.unipi.it> References: <201401160020.s0G0KgwY004039@svn.freebsd.org> <20140117044254.GB56239@onelab2.iet.unipi.it> Date: Thu, 16 Jan 2014 22:33:21 -0800 X-Google-Sender-Auth: -yOH-gBWh43N9qfhnAn6QICLW0I Message-ID: Subject: Re: svn commit: r260700 - in head: sys/dev/netmap tools/tools/netmap From: hiren panchasara To: Luigi Rizzo Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head , Luigi Rizzo , src-committers , svn-src-all X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jan 2014 06:33:24 -0000 On Thu, Jan 16, 2014 at 8:42 PM, Luigi Rizzo wrote: > On Thu, Jan 16, 2014 at 12:46:10PM -0800, hiren panchasara wrote: >> On Wed, Jan 15, 2014 at 4:20 PM, Luigi Rizzo wrote: >> > Author: luigi >> > Date: Thu Jan 16 00:20:42 2014 >> > New Revision: 260700 >> > URL: http://svnweb.freebsd.org/changeset/base/260700 >> > >> > Log: >> > netmap_user.h: >> > add separate rx/tx ring indexes >> > add ring specifier in nm_open device name >> > >> > netmap.c, netmap_vale.c >> > more consistent errno numbers >> > >> > netmap_generic.c >> > correctly handle failure in registering interfaces. >> > >> > tools/tools/netmap/ >> > massive cleanup of the example programs >> > (a lot of common code is now in netmap_user.h.) >> > >> > nm_util.[ch] are going away soon. >> > pcap.c will also go when i commit the native netmap support for libpcap. >> > >> > Modified: >> > head/sys/dev/netmap/netmap.c >> > head/sys/dev/netmap/netmap_generic.c >> > head/sys/dev/netmap/netmap_vale.c >> > head/tools/tools/netmap/Makefile >> > head/tools/tools/netmap/bridge.c >> > head/tools/tools/netmap/nm_util.c >> > head/tools/tools/netmap/nm_util.h >> > head/tools/tools/netmap/pcap.c >> > head/tools/tools/netmap/pkt-gen.c >> > head/tools/tools/netmap/vale-ctl.c >> > >> >> Hi Luigi, >> >> Doing make in tools/tools/netmap gives me a bunch of errors because >> "struct nm_desc_t" doesn't have members like if_flags, if_reqcap and >> if_curcap. It seems those members were coming from struct my_ring >> which is no more there. > > sorry my bad, i forgot to include sys/net/netmap_user.h in the commit. > Fixed in rev 260803 Thank you, Hiren