From owner-freebsd-current Sun Dec 17 13:15:46 2000 From owner-freebsd-current@FreeBSD.ORG Sun Dec 17 13:15:43 2000 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from dt051n37.san.rr.com (dt051n37.san.rr.com [204.210.32.55]) by hub.freebsd.org (Postfix) with ESMTP id 1545C37B400; Sun, 17 Dec 2000 13:15:43 -0800 (PST) Received: from gorean.org (Studded@master [10.0.0.2]) by dt051n37.san.rr.com (8.9.3/8.9.3) with ESMTP id NAA23080; Sun, 17 Dec 2000 13:15:42 -0800 (PST) (envelope-from DougB@gorean.org) Sender: doug@dt051n37.san.rr.com Message-ID: <3A3D2CFD.8572F575@gorean.org> Date: Sun, 17 Dec 2000 13:15:41 -0800 From: Doug Barton Organization: Triborough Bridge & Tunnel Authority X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: Poul-Henning Kamp Cc: current@freebsd.org Subject: Re: test/review: /dev/console logging patch References: <20743.977081023@critter> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Poul-Henning Kamp wrote: > > This patch is for the printf(9), log(9) & /dev/console stuff. > The result is that you can watch the output from /etc/rc in > your /var/log/messages. This works spectacularly for me on a UP -current with up to date sources. The only nit I have is that it doesn't understand lines that don't end in a newline very well (such as echo -n, or a printf with no \n), so it produces log output like this: Dec 17 13:00:24 Master /boot/kernel/kernel: /dev/da1s1a: Dec 17 13:00:24 Master /boot/kernel/kernel: FILESYSTEM CLEAN; SKIPPING CHECKS Dec 17 13:00:24 Master /boot/kernel/kernel: /dev/da1s1a: Dec 17 13:00:24 Master /boot/kernel/kernel: clean, 42202 free Dec 17 13:00:24 Master /boot/kernel/kernel: (154 frags, 5256 blocks, 0.2% fragmentation) and Dec 17 13:00:26 Master /boot/kernel/kernel: Doing additional network setup: Dec 17 13:00:26 Master /boot/kernel/kernel: ntpdate Dec 17 13:00:26 Master /boot/kernel/kernel: ntpd Dec 17 13:00:27 Master /boot/kernel/kernel: portmap Dec 17 13:00:27 Master /boot/kernel/kernel: . Now, the first isn't a big deal, but the second is a little confusing. Would there be any harm to changing the dots to something more meaningful, like "Done with additional network setup" on its own line? I seriously considered that when I was working on the echo's last night, but I didn't want to be too revolutionary. :) Doug -- "The most difficult thing in the world is to know how to do a thing and to watch someone else do it wrong without comment." -- Theodore H. White Do YOU Yahoo!? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message