From owner-freebsd-current@FreeBSD.ORG  Fri May  7 16:56:03 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@www.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1849916A4CF
	for <freebsd-current@www.freebsd.org>;
	Fri,  7 May 2004 16:56:03 -0700 (PDT)
Received: from arginine.spc.org (arginine.spc.org [195.206.69.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2CE7443D53
	for <freebsd-current@www.freebsd.org>;
	Fri,  7 May 2004 16:56:02 -0700 (PDT)	(envelope-from bms@spc.org)
Received: from localhost (localhost [127.0.0.1])
	by arginine.spc.org (Postfix) with ESMTP
	id 2C3B065371; Sat,  8 May 2004 00:56:00 +0100 (BST)
Received: from arginine.spc.org ([127.0.0.1])
 by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 45591-02; Sat,  8 May 2004 00:55:59 +0100 (BST)
Received: from empiric.dek.spc.org (82-147-17-88.dsl.uk.rapidplay.com
	[82.147.17.88])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by arginine.spc.org (Postfix) with ESMTP
	id 4461565213; Sat,  8 May 2004 00:55:57 +0100 (BST)
Received: by empiric.dek.spc.org (Postfix, from userid 1001)
	id 7435460EE; Sat,  8 May 2004 00:55:56 +0100 (BST)
Date: Sat, 8 May 2004 00:55:56 +0100
From: Bruce M Simpson <bms@spc.org>
To: Tim Robbins <tjr@freebsd.org>
Message-ID: <20040507235556.GB37035@empiric.dek.spc.org>
References: <20040507092235.GA61837@stack.nl>
	<20040507100119.GA15782@cat.robbins.dropbear.id.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040507100119.GA15782@cat.robbins.dropbear.id.au>
cc: Marc Olzheim <marcolz@stack.nl>
cc: Poul-Henning Kamp <phk@phk.freebsd.dk>
cc: freebsd-current@www.freebsd.org
Subject: Re: Unified getcwd() implementation
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 May 2004 23:56:03 -0000

On Fri, May 07, 2004 at 08:01:19PM +1000, Tim Robbins wrote:
> Why is this necessary? Emulation of the Linux getcwd() syscall belongs
> in the Linux emulator. There is also some fairly blatantly plagiarised code
> in this patch.

I rolled the patch before I was a committer in response to an item on
PHK's JKH tasklist.

The getcwd() implementation in the Linux module is not inherently Linux
specific; but it does implement the name-finding without using the name
cache, by scanning directories. The patch merges the name cache and
non-name-cache based implementations of getcwd() to address the PRs which
Marc cited in his earlier message.

You seem to be concerned about plagiarism. Could you clarify or explain
your concerns?

BMS