From owner-freebsd-net@FreeBSD.ORG Wed Mar 17 04:41:38 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 93E6616A4CE for ; Wed, 17 Mar 2004 04:41:38 -0800 (PST) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id D173E43D6B for ; Wed, 17 Mar 2004 04:41:37 -0800 (PST) (envelope-from glebius@cell.sick.ru) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.9/8.12.8) with ESMTP id i2HCfZQE024449 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Mar 2004 15:41:36 +0300 (MSK) (envelope-from glebius@cell.sick.ru) Received: (from glebius@localhost) by cell.sick.ru (8.12.9/8.12.6/Submit) id i2HCfZDv024448; Wed, 17 Mar 2004 15:41:35 +0300 (MSK) Date: Wed, 17 Mar 2004 15:41:34 +0300 From: Gleb Smirnoff To: David Malone Message-ID: <20040317124134.GC23881@cell.sick.ru> Mail-Followup-To: Gleb Smirnoff , David Malone , freebsd-net@freebsd.org References: <200403171152.aa43952@salmon.maths.tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200403171152.aa43952@salmon.maths.tcd.ie> User-Agent: Mutt/1.5.6i cc: freebsd-net@freebsd.org Subject: Re: PPPoE buglet... X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2004 12:41:38 -0000 On Wed, Mar 17, 2004 at 11:52:53AM +0000, David Malone wrote: D> I spent a while trying to get PPPoE going through a Netopia smart D> modem last night. To cut a long story short, the values for D> PTT_RELAY_SID in src/sys/netgraph/ng_pppoe.h are wrong (at least D> when compared with tcpdump, linux and the RFC). We have: D> D> #if BYTE_ORDER == BIG_ENDIAN D> #define PTT_RELAY_SID (0x0106) D> #else D> #define PTT_RELAY_SID (0x0601) D> #endif D> D> but we should have: D> D> #if BYTE_ORDER == BIG_ENDIAN D> #define PTT_RELAY_SID (0x0110) D> #else D> #define PTT_RELAY_SID (0x1001) D> #endif Yes. This was noticed more than a year ago in kern/44936. D> Anyone object to my fixing it? The only thing I can think of that D> it might break would be people using ng_pppoe as a PPPoE relay with D> only ng_pppoe PPPoE clients. AFAIK, ng_pppoe is not able to act as a relay. Consequently, it never inserts incorrect tag. Thus no one uses incorrect tag and ng_pppoe never inserts it, the statement "case PTT_RELAY_SID" never returns true. Therefore, currently PTT_RELAY_SID is not used at all. So, fixing it won't break anything. And ng_pppoe based ACs will be able to work with relay agents, which is good. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE