From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Aug 29 18:00:31 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2CAE910656E0 for ; Sun, 29 Aug 2010 18:00:31 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E438B8FC18 for ; Sun, 29 Aug 2010 18:00:30 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7TI0Ug9018612 for ; Sun, 29 Aug 2010 18:00:30 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7TI0UdD018602; Sun, 29 Aug 2010 18:00:30 GMT (envelope-from gnats) Resent-Date: Sun, 29 Aug 2010 18:00:30 GMT Resent-Message-Id: <201008291800.o7TI0UdD018602@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ilia Skalozubov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E7CE4106566B for ; Sun, 29 Aug 2010 17:54:49 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id D78C68FC21 for ; Sun, 29 Aug 2010 17:54:49 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o7THsmLZ025993 for ; Sun, 29 Aug 2010 17:54:48 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o7THsm8F025992; Sun, 29 Aug 2010 17:54:48 GMT (envelope-from nobody) Message-Id: <201008291754.o7THsm8F025992@www.freebsd.org> Date: Sun, 29 Aug 2010 17:54:48 GMT From: Ilia Skalozubov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/150090: [patch] devel/sdl12: Mouse clicking doesn't work with sdl 1.2.14 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Aug 2010 18:00:31 -0000 >Number: 150090 >Category: ports >Synopsis: [patch] devel/sdl12: Mouse clicking doesn't work with sdl 1.2.14 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 29 18:00:30 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Ilia Skalozubov >Release: >Organization: >Environment: >Description: When using SDL 1.2.14, some apps doesn't accept mouse clicks when running in windowed mode. Detail descriptions of the problem: - http://bugzilla.libsdl.org/show_bug.cgi?id=894 - http://gna.org/bugs/index.php?14770 >How-To-Repeat: >Fix: Patch attached with submission follows: --- src/video/x11/SDL_x11events.c.orig 2010-08-29 20:13:12.455316094 +0300 +++ src/video/x11/SDL_x11events.c 2010-08-29 20:14:46.875763077 +0300 @@ -441,8 +441,10 @@ if ( xevent.xcrossing.mode == NotifyUngrab ) printf("Mode: NotifyUngrab\n"); #endif - if ( xevent.xcrossing.detail != NotifyInferior ) { - if ( this->input_grab == SDL_GRAB_OFF ) { + if ( (xevent.xcrossing.mode != NotifyGrab) && + (xevent.xcrossing.mode != NotifyUngrab) && + (xevent.xcrossing.detail != NotifyInferior) ) { + if ( this->input_grab == SDL_GRAB_OFF ) { posted = SDL_PrivateAppActive(0, SDL_APPMOUSEFOCUS); } else { posted = SDL_PrivateMouseMotion(0, 0, >Release-Note: >Audit-Trail: >Unformatted: