From owner-svn-src-all@FreeBSD.ORG Fri May 22 10:53:17 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 04F33284; Fri, 22 May 2015 10:53:17 +0000 (UTC) Received: from kif.fubar.geek.nz (kif.fubar.geek.nz [178.62.119.249]) by mx1.freebsd.org (Postfix) with ESMTP id C36DC12DA; Fri, 22 May 2015 10:53:16 +0000 (UTC) Received: from bender (bender.sec.cl.cam.ac.uk [IPv6:2001:630:212:2a8:4e72:b9ff:fe93:61bf]) by kif.fubar.geek.nz (Postfix) with ESMTPSA id 6BE3AD7A6F; Fri, 22 May 2015 10:53:15 +0000 (UTC) Date: Fri, 22 May 2015 11:53:15 +0100 From: Andrew Turner To: Oleksandr Tymoshenko Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283275 - head/sys/dev/fdt Message-ID: <20150522115315.5e2ba6fa@bender> In-Reply-To: <201505220200.t4M20jfi082771@svn.freebsd.org> References: <201505220200.t4M20jfi082771@svn.freebsd.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; amd64-portbld-freebsd10.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2015 10:53:17 -0000 On Fri, 22 May 2015 02:00:45 +0000 (UTC) Oleksandr Tymoshenko wrote: > Author: gonzo > Date: Fri May 22 02:00:44 2015 > New Revision: 283275 > URL: https://svnweb.freebsd.org/changeset/base/283275 > > Log: > Add helper method fdt_find_child to make access to child nodes > easier. > Some FDT nodes have complex properties organized as a child > sub-nodes (e.g. timing for LCD panel) we need easy way to obtain > handles for these sub-nodes Why is this named fdt_find_child? It's not fdt specific so should be named something like ofw_bus_find_child and live in sys/dev/ofw/ofw_bus_subr.c. In general we are trying to move away from the fdt_ functions unless absolutely needed. Andrew