From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Sep 5 22:30:09 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C3E0710656DB for ; Sun, 5 Sep 2010 22:30:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 98B658FC17 for ; Sun, 5 Sep 2010 22:30:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o85MU9UH090129 for ; Sun, 5 Sep 2010 22:30:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o85MU9F6090118; Sun, 5 Sep 2010 22:30:09 GMT (envelope-from gnats) Date: Sun, 5 Sep 2010 22:30:09 GMT Message-Id: <201009052230.o85MU9F6090118@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Philip Paeps Cc: Subject: Re: ports/150235: sysutils/smartmontools build system bug X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Philip Paeps List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Sep 2010 22:30:09 -0000 The following reply was made to PR ports/150235; it has been noted by GNATS. From: Philip Paeps To: Alex Samorukov Cc: Doug Barton , Garrett Wollman , bug-followup@FreeBSD.org, developers@FreeBSD.org Subject: Re: ports/150235: sysutils/smartmontools build system bug Date: Mon, 6 Sep 2010 00:22:08 +0200 On 2010-09-06 00:06:54 (+0200), Alex Samorukov wrote: > On 09/05/2010 11:44 PM, Doug Barton wrote: > > On 09/05/2010 12:28 PM, Alex Samorukov wrote: > >> Your proposed patch will break smartmontools functionality - thats why > >> i`m not able to accept it. > > > > It's not at all clear to me why developers@ is cc'ed on these > > messages, but since we are ... > > > > Alex, > > > > Can you please explain why the change Garrett is suggesting will break > > anything? According to his PR all the headers that smartmontools needs > > are included in /usr/include. Is that not the case? > It is not the case. cciss.cpp from the sources uses dev/ciss/cissio.h to > work with cciss devices on FreeBSD. configure script checks if this file > is exists on the compile time, and if its not - does not compile cciss > support in the smartmontools. > If user will try to use cciss driver in this case - smartmontools will > display an error: > > "CCISS support is not available in this build of smartmontools,\n" > "/usr/src/sys/dev/ciss/cissio.h was not available at build time.\n\n"); If that interface is public (which it seems to be, from glancing at the file), the header should be installed in /usr/include/sys. There are precedents for this, see and (and presumably others). Any reason not to follow Garrett's suggestion to work with a src developer, perhaps one of the ones listed in the header file you need, to have it put somewhere public? - Philip -- Philip Paeps Please don't Cc me, I am philip@freebsd.org subscribed to the list.