From owner-cvs-all Mon Feb 12 6:41:55 2001 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 974FE37B401; Mon, 12 Feb 2001 06:41:43 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.2/8.11.2) id f1CEfd208020; Mon, 12 Feb 2001 17:41:40 +0300 (MSK) (envelope-from ache) Date: Mon, 12 Feb 2001 17:41:38 +0300 From: "Andrey A. Chernov" To: Alexey Zelkin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/locale lmessages.c lmonetary.c lnumeric.c Message-ID: <20010212174137.A7981@nagual.pp.ru> References: <200102120856.f1C8ueE34452@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200102120856.f1C8ueE34452@freefall.freebsd.org>; from phantom@FreeBSD.org on Mon, Feb 12, 2001 at 12:56:40AM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, Feb 12, 2001 at 00:56:40 -0800, Alexey Zelkin wrote: > phantom 2001/02/12 00:56:40 PST > > Modified files: > lib/libc/locale lmessages.c lmonetary.c lnumeric.c > Log: > Make comparsions more clear (per style(9)) lmessages.c: as I already write if (ret == 0) { should be if (ret == 0 && _messages_using_locale) { (and second time too). BTW it is strange to load shorter locale once again (i.e. repeat stdio read) while it is already in the buffer. The code should be rewritted in the manner as old timelocal.c did, i.e. return back line count. Using this line count, upper level code must decide which form of locale (short, long, broken) is loaded. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message