From owner-cvs-all@FreeBSD.ORG Wed Nov 19 16:34:54 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B3FF16A4CE for ; Wed, 19 Nov 2003 16:34:54 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 247B443FEA for ; Wed, 19 Nov 2003 16:34:52 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 69774 invoked by uid 1000); 20 Nov 2003 00:34:53 -0000 From: Nate Lawson To: John Baldwin In-Reply-To: Message-ID: <20031119160312.A69420@root.org> References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/acpica acpi.c acpi_cpu.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Thu, 20 Nov 2003 00:34:54 -0000 X-Original-Date: Wed, 19 Nov 2003 16:34:53 -0800 (PST) X-List-Received-Date: Thu, 20 Nov 2003 00:34:54 -0000 On Wed, 19 Nov 2003, John Baldwin wrote: > One minor suggestion btw. Could you fix the hw.acpi.cpu.cpu_cx_lowest > to use the "C1", "C2", and "C3" strings for its user-visible interface > instead of the direct integer? Setting the value to C2 is a bit more > intuitive than setting it to 1 to get C2. I considered this before, however Cx is really a type, not a given state. There can be more than 3 sleep states. For instance, the IBM R40 has C1, C2, C3, and C3 (4 states). An index was the only unique way I could specify the states. The transition latency is also unique but setting a state to 182 to get the last C3 state is even worse from a user perspective. -Nate