From owner-cvs-src@FreeBSD.ORG Mon Jun 11 07:50:25 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7FFC916A469 for ; Mon, 11 Jun 2007 07:50:25 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id D595413C48A for ; Mon, 11 Jun 2007 07:50:24 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 80943 invoked from network); 11 Jun 2007 07:04:12 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 11 Jun 2007 07:04:12 -0000 Message-ID: <466CFEC1.6080100@freebsd.org> Date: Mon, 11 Jun 2007 09:50:25 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: pyunyh@gmail.com References: <200706110155.l5B1t9d9043150@repoman.freebsd.org> <466CFBE2.1090907@freebsd.org> <20070611074456.GE39661@cdnetworks.co.kr> In-Reply-To: <20070611074456.GE39661@cdnetworks.co.kr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, rwatson@freebsd.org, cvs-all@freebsd.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/msk if_msk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2007 07:50:25 -0000 Pyun YongHyeon wrote: > On Mon, Jun 11, 2007 at 09:38:10AM +0200, Andre Oppermann wrote: > > Pyun YongHyeon wrote: > > >yongari 2007-06-11 01:55:09 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/msk if_msk.c > > > Log: > > > Disable automatic IP ID increment. Due to a hardware bug the automatic > > > IP ID increment in TSO case generated corrupted IP packets. > > > This change brings back TSO capability. > > > > > > Revision Changes Path > > > 1.16 +0 -15 src/sys/dev/msk/if_msk.c > > > > Please add check for the DF (Don't fragment) bit in the IP header. > > Otherwise we may run into trouble when fragmentation happens along > > the path. We almost always set DF on TCP connections. If it is not > > set please return EMSGSIZE which will cause TSO to be turned off. > > > > Is there any way to return EMSGSIZE to upper layer? > if_start has return type void. > Or just dropping the packet if DF bit was not set is enough? Dropping the packet is not enough. I forgot the IF queue which separates the downpath from the encap function... Don't know how you can pass up the error. Robert wanted to change the drivers queuing model, that would make it possible. CC'ed. -- Andre