From owner-svn-src-all@FreeBSD.ORG Mon Dec 6 19:22:48 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B004106566B; Mon, 6 Dec 2010 19:22:48 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id EF3918FC12; Mon, 6 Dec 2010 19:22:47 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 820E745C8A; Mon, 6 Dec 2010 20:22:46 +0100 (CET) Received: from localhost (89-73-192-49.dynamic.chello.pl [89.73.192.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 071B045684; Mon, 6 Dec 2010 20:22:39 +0100 (CET) Date: Mon, 6 Dec 2010 20:22:38 +0100 From: Pawel Jakub Dawidek To: Ivan Voras Message-ID: <20101206192238.GB1936@garage.freebsd.pl> References: <201012061218.oB6CI3oW032770@svn.freebsd.org> <20101206184453.GA1936@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6sX45UoQRIJXqkqR" Content-Disposition: inline In-Reply-To: <20101206184453.GA1936@garage.freebsd.pl> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Dec 2010 19:22:48 -0000 --6sX45UoQRIJXqkqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 06, 2010 at 07:44:53PM +0100, Pawel Jakub Dawidek wrote: > On Mon, Dec 06, 2010 at 12:18:03PM +0000, Ivan Voras wrote: > > Author: ivoras > > Date: Mon Dec 6 12:18:02 2010 > > New Revision: 216230 > > URL: http://svn.freebsd.org/changeset/base/216230 > >=20 > > Log: > > Use GEOM stripesize field when calculating ashift. This will enable c= orrect > > alignment on drives with large sector sizes (e.g. 4 KiB) but the > > implementation might need to be revisited if devices with large strip= esizes > > appear (e.g. if RAID controllers or flash drives start using the fiel= d), > > probably by introducing a physsectorsize field in GEOM providers. >=20 > Please back this out as soon as possible! >=20 > > Discussed with: mav, mostly silence on freebsd-geom@ and freebsd-fs@ >=20 > Guess why it wasn't picked up by anyone? In other words... Stop hack around. This is so irritating. If disk lies about its sector size, add quirks at the layer where disk is discovered. Don't hack ZFS, UFS, any other file system and GEOM classes, because its easiest for you. It would be best if you could just leave it to mav@ who knows this area and knows what he is doing. Those drive-by hacks of yours are really doing more evil than good. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --6sX45UoQRIJXqkqR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkz9N/4ACgkQForvXbEpPzTfggCgq7eYEyaWA3WqRf30aTjbXAdz bmgAn02nrHToylxD4400nWV0JlJJ3D7c =MLBv -----END PGP SIGNATURE----- --6sX45UoQRIJXqkqR--