From owner-svn-src-all@FreeBSD.ORG Mon Dec 7 04:31:23 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7866B1065679 for ; Mon, 7 Dec 2009 04:31:23 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.10]) by mx1.freebsd.org (Postfix) with ESMTP id 0FAE78FC14 for ; Mon, 7 Dec 2009 04:31:22 +0000 (UTC) Received: from vampire.homelinux.org (dslb-088-064-179-227.pools.arcor-ip.net [88.64.179.227]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0MgYIJ-1NUVh91qtz-00NNxF; Mon, 07 Dec 2009 05:31:21 +0100 Received: (qmail 4820 invoked from network); 7 Dec 2009 04:31:18 -0000 Received: from f8x64.laiers.local (192.168.4.188) by router.laiers.local with SMTP; 7 Dec 2009 04:31:18 -0000 From: Max Laier Organization: FreeBSD To: Luigi Rizzo Date: Mon, 7 Dec 2009 05:31:17 +0100 User-Agent: KMail/1.12.1 (FreeBSD/8.0-RELEASE; KDE/4.3.1; amd64; ; ) References: <200912061804.nB6I4R38027652@svn.freebsd.org> In-Reply-To: <200912061804.nB6I4R38027652@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <200912070531.17758.max@love2party.net> X-Provags-ID: V01U2FsdGVkX19/ErNRu7wMUlZtxiGOkV6MJA+JkJu3oJd9GE4 jvGHz3rPBjI+FBq4P264Wr/AGfLKASBHiRPr6RSbCy92HxMAUt 2AFWQLAQ64E3R/XTdhhrQ== Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r200183 - head/sbin/ipfw X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2009 04:31:23 -0000 On Sunday 06 December 2009 19:04:27 Luigi Rizzo wrote: > Author: luigi > Date: Sun Dec 6 18:04:26 2009 > New Revision: 200183 > URL: http://svn.freebsd.org/changeset/base/200183 > > Log: > restore setting of sin_len (was removed in 1.146 last february) as > it seems that now it is necessary for 'forward' to work outside lo0. > The bug (and fix) was reported on 8.0. This patch probably applies > to RELENG_7 as well. > It seems that 'pf' has a similar bug. > > Submitted by: Lytochkin Boris Do you have a reference for me? > MFC after: 3 days > > Modified: > head/sbin/ipfw/ipfw2.c > > Modified: head/sbin/ipfw/ipfw2.c > =========================================================================== > === --- head/sbin/ipfw/ipfw2.c Sun Dec 6 17:26:43 2009 (r200182) > +++ head/sbin/ipfw/ipfw2.c Sun Dec 6 18:04:26 2009 (r200183) > @@ -2740,9 +2740,11 @@ chkarg: > > /* > * In the kernel we assume AF_INET and use only > - * sin_port and sin_addr. > + * sin_port and sin_addr. Remember to set sin_len as > + * the routing code seems to use it too. > */ > p->sa.sin_family = AF_INET; > + p->sa.sin_len = sizeof(struct sockaddr_in); > p->sa.sin_port = 0; > /* > * locate the address-port separator (':' or ',') > > > !DSPAM:4b1bf5b9894172410716004! >