From owner-cvs-all@FreeBSD.ORG  Sat Feb 25 22:04:41 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D40D316A420;
	Sat, 25 Feb 2006 22:04:41 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 65ADB43D48;
	Sat, 25 Feb 2006 22:04:41 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k1PM4eWW026946;
	Sat, 25 Feb 2006 15:04:40 -0700 (MST)
	(envelope-from scottl@samsco.org)
Message-ID: <4400D478.7060707@samsco.org>
Date: Sat, 25 Feb 2006 15:04:40 -0700
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20051230
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Maksim Yevmenkin <emax@FreeBSD.org>
References: <200602252159.k1PLxT8G036312@repoman.freebsd.org>
In-Reply-To: <200602252159.k1PLxT8G036312@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/kbdmux kbdmux.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Feb 2006 22:04:42 -0000

Maksim Yevmenkin wrote:
> emax        2006-02-25 21:59:29 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/kbdmux       kbdmux.c 
>   Log:
>   Fix hard lockup caused by kbdmux(4) when kbdmux(4), PS/2 keyboard
>   (atkbd(4)) and PS/2 mouse (psm(4)) are used together.
>   
>   Turns out that atkbd(4) check_char() method may return "true" while
>   read_char() method returns NOKEY. When this happens kbdmux(4) was
>   simply stuck in the dead loop. Avoid dead loop in kbdmux(4) by breaking
>   out of the loop if read_char() method returns NOKEY.
>   
>   It almost seems like a bug in atkkbd(4), atkbd_check_char() calls
>   kbdc_data_ready(), and, the later will return "true" if there are
>   pending data in either kbd or aux queue. However, because both aux
>   and kbd are on the same controller, I'm not sure if this is a bug
>   or feature.
>   
>   Tested by:      markus
>   MFC after:      1 day
>   
>   Revision  Changes    Path
>   1.4       +1 -1      src/sys/dev/kbdmux/kbdmux.c

So what do we need to do to get this enabled and running by default and
get rid of the USB keyboard hack in the loader, as well as make the
keyboard flags sane and predictable?

Scott