From owner-svn-ports-head@freebsd.org Thu Sep 10 02:17:27 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C975AA01CEB; Thu, 10 Sep 2015 02:17:27 +0000 (UTC) (envelope-from jason.unovitch@gmail.com) Received: from mail-qg0-x22c.google.com (mail-qg0-x22c.google.com [IPv6:2607:f8b0:400d:c04::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 80EE21EDF; Thu, 10 Sep 2015 02:17:27 +0000 (UTC) (envelope-from jason.unovitch@gmail.com) Received: by qgez77 with SMTP id z77so24840314qge.1; Wed, 09 Sep 2015 19:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=OtsG3oTtt/fh0WlFhaINrzZP1f4Hax5HOxM/Y2qPgDg=; b=EWCCA3MOKBG02T9LxX2VeeLGy0BT9ucjSGykmb+CDvURsY7+iLQej8p3Vui/zdeHUB 6auDrgUeAIKPt0mKgt1gsdptnkWOudSkih4nPgBdFFx0fmf5Ie3yZrJQFXMTs+zjVuuA GHbkMFOIGOXssY/1NDmN9Zb/igS7u8H7uc4ciXBfmJ5WelKUyAopzh3EINFxwIMDEq7N V53hlbqmaYqC3HiQzPRoLCZi1crrIVoeau6mViy/6diebEZUesV5cy1czQBRKQxCdWkn 78lqYbAOYYILv10bKzVkPpzZkPpCIv1n9/1AIEZV4ouFOpT1pyZXweVxIKRkHU3wfhmM VkWg== X-Received: by 10.140.164.7 with SMTP id k7mr52540035qhk.40.1441851446618; Wed, 09 Sep 2015 19:17:26 -0700 (PDT) Received: from Silverstone.nc-us.unovitch.com (cpe-98-24-222-249.nc.res.rr.com. [98.24.222.249]) by smtp.gmail.com with ESMTPSA id y7sm5155723qky.20.2015.09.09.19.17.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Sep 2015 19:17:26 -0700 (PDT) Date: Wed, 9 Sep 2015 22:17:23 -0400 From: Jason Unovitch To: "Philip M. Gollucci" Cc: Jan Beich , Jason Unovitch , "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Chris Hutchinson , "ports-committers@freebsd.org" Subject: Re: svn commit: r396547 - in head/textproc: . smi Message-ID: <20150910021723.GA7969@Silverstone.nc-us.unovitch.com> Reply-To: junovitch@FreeBSD.org References: <201509100045.t8A0jQFW087140@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2015 02:17:27 -0000 On Wed, Sep 09, 2015 at 10:06:07PM -0400, Philip M. Gollucci wrote: > Well gosh. I must not approve things while crszy. > > Thanks Jan! Seconded! Thanks Jan. > > On Wednesday, September 9, 2015, Jan Beich wrote: > > > Jason Unovitch writes: > > > > > +post-patch: > > > + ${REINPLACE_CMD} -e 's|^CC = .*|CC = ${CC}|' \ > > > > CC is defined by default to a sane value in both GNU and BSD make. > > One can do '/^CC/d' but see below for better way. The intent was to catch the hard coded CC = cc in the port's config.mk. This port doesn't seem to respect getting CC passed by MAKE_ENV. > > > > > + -e 's|^PREFIX = .*|PREFlX = ${PREFIX}|' \ > > ^^^ > > Typo: l .vs I. It still works because PREFIX is also passed via MAKE_ENV. I'm not sure how I managed to miss that one. > > > > > + -e 's|^MANPREFIX = .*|MANPREFIX = ${MANPREFIX}|' \ > > > + ${WRKSRC}/config.mk > > > > If possible try to avoid patching makefiles if overriding a few > > variables is enough. For one, your entire post-patch can be: > > > > MAKE_ARGS= CC="${CC}" PREFIX="${PREFIX}" MANPREFIX="${MANPREFIX}" > > > Working on the corrections now. Thanks again!