From owner-freebsd-hackers Wed Oct 30 16:08:57 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id QAA11218 for hackers-outgoing; Wed, 30 Oct 1996 16:08:57 -0800 (PST) Received: from tahoma.cwu.edu (skynyrd@tahoma.cwu.edu [198.104.65.220]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id QAA11208 for ; Wed, 30 Oct 1996 16:08:55 -0800 (PST) Received: by tahoma.cwu.edu; id AA10239; Wed, 30 Oct 1996 16:08:36 -0800 Date: Wed, 30 Oct 1996 16:08:36 -0800 (PST) From: Chris Timmons To: Joerg Wunsch Cc: FreeBSD hackers Subject: Re: Verbose babble in if_fddisubr.c In-Reply-To: <199610301638.RAA06231@ida.interface-business.de> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-hackers@freebsd.org X-Loop: FreeBSD.org Precedence: bulk I had the same thing happen to me recently and I submitted kern/1859 as a low-priority change request. Care to fix it? :) -Chris On Wed, 30 Oct 1996, J Wunsch wrote: > Hi all, > > i've just got a call by a customer who's using a DEC DEFPA FDDI card > now. She told me that everything works fine (once i've pointed her to > the `pseudo-device fddi') but has been a little scared by some verbose > babble caused by the driver. > > After digging around and looking up the error messages, it looks to me > that they've got all kinds of weird frames and packets on their wire, > so the following two printf's hit often enough: > > (sys/net/if_fddisubr.c) > > default: > printf("fddi_input: unknown protocol 0x%x\n", fddi_type); > > ... > default: > printf("fddi_input: unknown dsap 0x%x\n", l->llc_dsap); > ifp->if_noproto++; > > I think both printf's are merely nice debugging aids to see all the > garbage that flies along your wire :), but nothing to be dropped onto > a regular user. I therefore suggest hiding them inside either some > #ifdef, or at least behind `bootverbose'. > > -- > J"org Wunsch Unix support engineer > joerg_wunsch@interface-business.de http://www.interface-business.de/~j >