From owner-freebsd-standards@FreeBSD.ORG Fri Feb 22 16:08:13 2013 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 97903632 for ; Fri, 22 Feb 2013 16:08:13 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm25-vm3.bullet.mail.gq1.yahoo.com (nm25-vm3.bullet.mail.gq1.yahoo.com [98.136.217.114]) by mx1.freebsd.org (Postfix) with ESMTP id 5581499D for ; Fri, 22 Feb 2013 16:08:13 +0000 (UTC) Received: from [98.137.12.188] by nm25.bullet.mail.gq1.yahoo.com with NNFMP; 22 Feb 2013 16:01:14 -0000 Received: from [98.136.185.45] by tm9.bullet.mail.gq1.yahoo.com with NNFMP; 22 Feb 2013 16:01:14 -0000 Received: from [127.0.0.1] by smtp106.mail.gq1.yahoo.com with NNFMP; 22 Feb 2013 16:01:14 -0000 X-Yahoo-Newman-Id: 831789.33090.bm@smtp106.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: T2WMbKsVM1kRSgufr8tM1GkE6zcZGGL_q1jGdQ0TIfJPiQ. MFSwAK5ek8kL83YZDMH81kYMCavm0ChWCQQiJP.syL06vz.lJ_2xboguop83 7sGPmkfTNyZiRBwY.Ic6CCqgvtMnbxNrNJpyrJP8ZL.B4Zi7Y3lyhr_XHYGl GJAryX3r0.vB_57f4RAuF7zjmmxuv8ADCpZ13R6FggpN5EXec569IkDF3VcA 7KQwHgBO5NkRAPo411RKYSfellwvfjTjwcDeyqwcA5ypIkGpNR4nipoFZrHd D4pWxJSI7PG7Rk.MeHEQVVGENB7oACpmbZkfRApYGSJOZbscGg_BH8DDIWqe Psr5MuYZnVvCMoPX58nX3VGaRLmXHCRt9gvCN1rUI3zI0r9jByGlHFQiG0C4 mmp07oUSm6U1iGoS_I2iGlT4GJZ8kbWoO8GyW_gfr9Atxg8GgSFxONH3DlrO jPdNXPOXFFHreHp6M1tJ50RLr8pA6FItsuJ9KRS5APR.aIstsv1.XLji5yPR WcLNO9lmLQrvppxKRKy0bPiUx9xSWhZz_Ur54.uEvRQcLUq4- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Received: from [192.168.10.102] (pfg@200.118.157.7 with plain) by smtp106.mail.gq1.yahoo.com with SMTP; 22 Feb 2013 08:01:14 -0800 PST Message-ID: <5127964D.5080005@FreeBSD.org> Date: Fri, 22 Feb 2013 11:01:17 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130201 Thunderbird/17.0.2 MIME-Version: 1.0 To: David Chisnall Subject: Re: standards/175811: libstdc++ needs complex support in order use C99 References: <201302040328.r143SUd3039504@freefall.freebsd.org> <510F306A.6090009@missouri.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Stephen Montgomery-Smith , freebsd-numerics@FreeBSD.org, freebsd-standards@FreeBSD.org X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2013 16:08:13 -0000 Hello guys; On 02/22/2013 04:54, David Chisnall wrote: > On 4 Feb 2013, at 03:52, Stephen Montgomery-Smith wrote: > >> We do really seem to have a lot of working code right now. And the main >> barrier to commitment seems to be style issues. >> >> For example, I have code at http://people.freebsd.org/~stephen/ for the >> complex arctrig functions. And Bruce has clog available. And >> presumably he has logl and atanl also available. >> >> The last I heard about my code is Bruce asking for some style changes. >> However I really don't think I will have time to work on it until at >> least the summer. And to be honest, style just isn't my thing. >> >> I propose (a) that someone else takes over my code (and maybe Bruce's >> code) and make the style changes, or (b) that we get a little less fussy >> about getting it all just so right and start committing stuff. >> >> Let me add that the code we have is already far superior than anything >> in Linux or NetBSD, who clearly didn't worry about huge numerical errors >> in many edge cases. Come on guys, let's start strutting our stuff. >> >> Let's commit what we have, even if it isn't perfect. > Yes, please can this happen? We are currently on 31 test failures in the libc++ test suite on -HEAD, of which at least 18 are due to linker failures trying to find missing libm functions. We are very close to having a complete C++11 implementation, yet we are held up by the lack of C99 support, and we are held up there by style nits? > > On behalf of core, please can we commit the existing code and worry about the style later? Given the expertise required to work on the libm functions, most of the people who are able to hack on the code have already read it and so concerns about consistency readability are somewhat misplaced. The problem is not really lack of committers I guess ;). Can the numeric guys just put a patch together for testing? Pedro.