From owner-cvs-all@FreeBSD.ORG Sun Aug 20 16:13:01 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8008616A4DD; Sun, 20 Aug 2006 16:13:01 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from sccmmhc91.asp.att.net (sccmmhc91.asp.att.net [204.127.203.211]) by mx1.FreeBSD.org (Postfix) with ESMTP id 92F0543D53; Sun, 20 Aug 2006 16:12:58 +0000 (GMT) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net ([12.207.12.9]) by sccmmhc91.asp.att.net (sccmmhc91) with ESMTP id <20060820161253m910086b0ae>; Sun, 20 Aug 2006 16:12:57 +0000 Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.6/8.13.6) with ESMTP id k7KGClNG042026; Sun, 20 Aug 2006 11:12:47 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.6/8.13.6/Submit) id k7KGCkGb041202; Sun, 20 Aug 2006 11:12:46 -0500 (CDT) (envelope-from brooks) Date: Sun, 20 Aug 2006 11:12:42 -0500 From: Brooks Davis To: Yar Tikhiy Message-ID: <20060820161242.GB95726@lor.one-eyed-alien.net> References: <200608181210.k7ICAIme084410@repoman.freebsd.org> <86ejvet9m6.fsf@xps.des.no> <20060818143310.GA14203@comp.chem.msu.su> <20060818143508.GA2545@lor.one-eyed-alien.net> <20060818153744.GA14726@comp.chem.msu.su> <20060818154240.GA3050@lor.one-eyed-alien.net> <20060819083245.GA23574@comp.chem.msu.su> <20060820040636.GA32859@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s/l3CgOIzMHHjg/5" Content-Disposition: inline In-Reply-To: <20060820040636.GA32859@comp.chem.msu.su> User-Agent: Mutt/1.5.11 Cc: src-committers@FreeBSD.org, Brooks Davis , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Garance A Drosehn , Dag-Erling Sm?rgrav Subject: Re: moving pgrep and pkill X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Aug 2006 16:13:01 -0000 --s/l3CgOIzMHHjg/5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 20, 2006 at 08:06:37AM +0400, Yar Tikhiy wrote: > On Sat, Aug 19, 2006 at 04:48:51PM -0400, Garance A Drosehn wrote: > > At 12:32 PM +0400 8/19/06, Yar Tikhiy wrote: > > >On Fri, Aug 18, 2006, Brooks Davis wrote: > > > > On Fri, Aug 18, 2006, Yar Tikhiy wrote: > > > > > On Fri, Aug 18, 2006, Brooks Davis wrote: > > > > > > On Fri, Aug 18, 2006, Yar Tikhiy wrote: > > > > > > | On Fri, Aug 18, 2006, Dag-Erling Sm?rgrav wrote: > > > > > > | > In a commit msg, Yar Tikhiy writes: > > > > > > | > > Log: > > > > > > | > > The ps(1) command is unfriendly to scripts by default > > > > > > | > > because it limits the width of its output to the value > > > > > > | > > of $COLUMNS, or what TIOCGWINSZ reports, or 79 columns. > > > > > > | > > We should specify -ww to ps(1) so that it removes the > > > > > > | > > limit and prints lines in full. Otherwise very long > > > > > > | > > command pathnames could be mishandled, e.g., > > > > > > | > > by _find_processes(). > > > > > > | > > > > > > > | > or perhaps _find_processes() should use pgrep(1) instead > > > > > > | > of ps(1). > > > > > > | > > > > > > | I considered that but had to stick to ps(1) because pgrep > > > > > > | was in /usr/bin while ps was in /bin. The use of /usr/bin > > > > > > | tools should be very limited in rc.subr(8). OTOH, pgrep > > > > > > | uses /lib libs only, which makes it possible to transfer > > > > > > | pgrep+pkill to /bin if we can stand the growth of / by > > > > > > | some 50 kbytes. > > > > > > > > > > > > I think that's appropriate since pgrep is such an obvious > > > > > > fit for this sort of thing. I think we'll want to consider > > > > > > compatability symlinks due to existing hardcoded paths in > > > > > > scripts. > >=20 > >=20 > > I do not mind if `pgrep' and `pkill' are moved to /bin. Note > > that these were added to /usr because that's where they exist > > on NetBSD, OpenBSD, Solaris and Linux. So we're not just > > talking about hardcoded-paths in a few scripts that FreeBSD > > users might have written for use only on FreeBSD. So, I expect > > we will want symlinks to remain in /usr, forever, if we move > > the programs to /bin. > >=20 > > (Moving them does seem reasonable to me. I'm just saying why > > they were put in /usr in the first place...) >=20 > Thank you! I'll add a comment to src/usr.bin/pkill/Makefile so that > the SYMLINKS lines aren't removed without thorough consideration. Sounds good. I don't think it's a problem to have the compat links around, we're talking two inodes after all. :) -- Brooks --s/l3CgOIzMHHjg/5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE6In6XY6L6fI4GtQRAorBAJ49y2GQiWAHLmfXwm7Tckl+cUlXLgCgokdw dK+wB38ZyFPvb9nHZ4mTZ7g= =lhxJ -----END PGP SIGNATURE----- --s/l3CgOIzMHHjg/5--