From owner-freebsd-usb@FreeBSD.ORG  Sat Jun 23 20:00:15 2007
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
X-Original-To: freebsd-usb@hub.freebsd.org
Delivered-To: freebsd-usb@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 20BBF16A41F
	for <freebsd-usb@hub.freebsd.org>; Sat, 23 Jun 2007 20:00:15 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id C3D2613C448
	for <freebsd-usb@hub.freebsd.org>; Sat, 23 Jun 2007 20:00:14 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l5NK0E6t095651
	for <freebsd-usb@freefall.freebsd.org>; Sat, 23 Jun 2007 20:00:14 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l5NK0EHZ095650;
	Sat, 23 Jun 2007 20:00:14 GMT (envelope-from gnats)
Date: Sat, 23 Jun 2007 20:00:14 GMT
Message-Id: <200706232000.l5NK0EHZ095650@freefall.freebsd.org>
To: freebsd-usb@FreeBSD.org
From: Kazuaki ODA <kazuaki@aliceblue.jp>
Cc: 
Subject: Re: usb/113964: [patch] ucom(4): kernel panic when dropping a
	connection
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Kazuaki ODA <kazuaki@aliceblue.jp>
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jun 2007 20:00:15 -0000

The following reply was made to PR usb/113964; it has been noted by GNATS.

From: Kazuaki ODA <kazuaki@aliceblue.jp>
To: "M. Warner Losh" <imp@bsdimp.com>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: usb/113964: [patch] ucom(4): kernel panic when dropping a connection
Date: Sun, 24 Jun 2007 04:56:22 +0900

 M. Warner Losh wrote:
 > In message: <200706231136.l5NBa61H001748@eyes.aliceblue.jp>
 >             Kazuaki ODA <kazuaki@aliceblue.jp> writes:
 > : 	I don't know the proper fix but the following patch is workaround for
 > : 	me.
 > : 
 > : --- ucom.c.patch begins here ---
 > : --- sys/dev/usb/ucom.c.orig	2007-06-22 23:45:37.000000000 +0900
 > : +++ sys/dev/usb/ucom.c	2007-06-23 17:47:18.000000000 +0900
 > : @@ -532,6 +532,9 @@
 > :  	if (sc->sc_dying)
 > :  		return;
 > :  
 > : +	if (sc->sc_oxfer == NULL)
 > : +		return;
 > : +
 > :  	s = spltty();
 > :  
 > :  	if (tp->t_state & TS_TBLOCK) {
 > : --- ucom.c.patch ends here ---
 > 
 > This is a good workaround.  However, why does the tty->t_oproc get
 > called after the tty->t_close routine which sets sc->sc_oxfer to NULL?
 > 
 > Warner
 
 Unfortunately, I have no idea.  But it seems the changes of tty 
 subsystem and ucom.c rev. 1.56 are related to the issue.
 
 * On 5.x-RELEASE, where ucom.c rev. 1.56 has been MFCed, we get no panic.
 
 * On 6.x-RELEASE or 7.0-CURRENT, we get a panic.
 
 * After backing out ucom.c rev. 1.56, no panic on 6.x-RELEASE or 
 7.0-CURRENT.
 
 -- 
 Kazuaki ODA