From owner-cvs-all@FreeBSD.ORG  Thu Jul 22 12:38:23 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 305F516A4CE; Thu, 22 Jul 2004 12:38:23 +0000 (GMT)
Received: from pinky.otenet.gr (pinky.otenet.gr [195.170.0.24])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E37A443D48; Thu, 22 Jul 2004 12:38:20 +0000 (GMT)
	(envelope-from keramida@ceid.upatras.gr)
Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr
	[62.103.39.226])i6MCc1Hk005718;	Thu, 22 Jul 2004 15:38:09 +0300
Received: from orion.daedalusnetworks.priv (orion [127.0.0.1])
	i6MCckjp016051;	Thu, 22 Jul 2004 15:38:46 +0300 (EEST)
	(envelope-from keramida@ceid.upatras.gr)
Received: (from keramida@localhost)i6MCciq2016050;
	Thu, 22 Jul 2004 15:38:44 +0300 (EEST)
	(envelope-from keramida@ceid.upatras.gr)
Date: Thu, 22 Jul 2004 15:38:44 +0300
From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: Tim Robbins <tjr@freebsd.org>
Message-ID: <20040722123844.GB5479@orion.daedalusnetworks.priv>
References: <200407220814.i6M8EbKM092483@repoman.freebsd.org>
	<20040722105914.GA4708@orion.daedalusnetworks.priv>
	<20040722115827.GA6110@cat.robbins.dropbear.id.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040722115827.GA6110@cat.robbins.dropbear.id.au>
cc: Ollivier Robert <roberto@freebsd.org>
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/usr.sbin/ntp config.h src/usr.sbin/ntp/ntpdc
	Makefile src/usr.sbin/ntp/ntpq Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jul 2004 12:38:23 -0000

On 2004-07-22 21:58, Tim Robbins <tjr@freebsd.org> wrote:
>On Thu, Jul 22, 2004 at 01:59:15PM +0300, Giorgos Keramidas wrote:
>>On 2004-07-22 08:14, Ollivier Robert <roberto@freebsd.org> wrote:
>>>
>>> Allow ntpd to be compiled w/o readline when NO_GNU is defined.  Part
>>> of a larger patchset to get a GNU-free world.
>>>
>>> Patch rewritten to cope with the 4.2.0 changes.
>>
>> Just a thought, without having looked at the source of ntp stuff.
>>
>> Would it be extremely difficult or cause conflict/merge problems if we
>> replaced readline with libedit in the NO_GNU case?
>
> NetBSD not-so-recently added GNU readline emulation to their libedit.
> Last time I looked, they'd made a mess of the code with #ifdefs, but it'd
> still be possible to bring across the useful bits.

Err, no that would be ugly.  I don't like excessive use of #ifdefs but
that's probably a different topic.

I was thinking of something more like: use this getline() function,
which will magically work through readline() or el_get() depending on
which file was added to SRCS at compile-time (depending on WITH_READLINE
or not).

> FWIW, I really don't see the point of partial support for building
> GNU-free systems. It sounds like something that should be kept as
> a local diff.

Hmmm, yes well...  I'll see if I can do something not too ugly but still
useful as a proof-of-concept diff when the commits to the ntp utils are
all done.