From owner-freebsd-gnome@freebsd.org Sat Jul 23 11:01:57 2016 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D001FBA1E86 for ; Sat, 23 Jul 2016 11:01:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B8EA1170D for ; Sat, 23 Jul 2016 11:01:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B84CCBA1E85; Sat, 23 Jul 2016 11:01:57 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7F0FBA1E84 for ; Sat, 23 Jul 2016 11:01:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A38C7170B for ; Sat, 23 Jul 2016 11:01:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u6NB1vJh061251 for ; Sat, 23 Jul 2016 11:01:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 211201] print/freetype2: update to 2.6.5, replace LCD_FILTERING with V40 code : [Attachment 172884] Proposed patch (since 412348 revision) Date: Sat, 23 Jul 2016 11:01:57 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jul 2016 11:01:57 -0000 lightside has asked gnome@FreeBSD.org for maintainer-approval: Bug 211201: print/freetype2: update to 2.6.5, replace LCD_FILTERING with V40 code https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211201 Attachment 172884: Proposed patch (since 412348 revision) https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172884&action=3Dedit --- Comment #10 from lightside --- Created attachment 172884 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172884&action= =3Dedit Proposed patch (since 412348 revision) Hello Piotr Kubaj and Jan Beich. I think, the replacement of "LCD_FILTERING with V40 code" is wrong proposal, because they are different options and defines: FT_CONFIG_OPTION_SUBPIXEL_RENDERING: https://www.freetype.org/freetype2/docs/reference/ft2-lcd_filtering.html https://www.freetype.org/freetype2/docs/reference/ft2-lcd_filtering.html#FT= _Lib rary_SetLcdFilter http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/include/freety= pe/c onfig/ftoption.h?id=3DVER-2-6-5#n78 TT_CONFIG_OPTION_SUBPIXEL_HINTING: https://www.freetype.org/freetype2/docs/reference/ft2-tt_driver.html#interp= rete r-version http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/include/freety= pe/c onfig/ftoption.h?id=3DVER-2-6-5#n586 The V40 option should not be enabled by default for v2.3.5 (as it was for v2.3.4), because of the following changes in v2.3.5: https://www.freetype.org -8<-- FreeType 2.6.5 2016-07-12 This release is almost identical to the previous version, with two differen= ces. - It compiles again on Mac OS X, and - it reverts the activation of subpixel hinting by default; it will be enab= led by default in the forthcoming 2.7.x series. Main reason for reverting this feature is the principle of least surprise: a sudden change in appearance of all fonts (even if the rendering improves for almost all recent fonts) shou= ld not be expected in a new micro version of a series. -->8- In docs/CHANGES file: http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/docs/CHANGES?i= d=3DVE R-2-6-5#n2 -8<-- CHANGES BETWEEN 2.6.4 and 2.6.5 I. IMPORTANT BUG FIXES - Compilation works again on Mac OS X (bug introduced in version 2.6.4). I. IMPORTANT CHANGES - The new subpixel hinting mode is now disabled by default; it will be enabled by default in the forthcoming 2.7.x series. Main reason for reverting this feature is the principle of least surprise: a sudden change in appearance of all fonts (even if the rendering improves for almost all recent fonts) should not be expected in a new micro version of a series. -->8- The FreeType 2 font engine is dual licensed: https://www.freetype.org/license.html http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/docs/LICENSE.T= XT?i d=3DVER-2-6-5 http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/docs/FTL.TXT?i= d=3DVE R-2-6-5 http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/docs/GPLv2.TXT= ?id=3D VER-2-6-5 Therefore, I would like to propose slightly different patch, with following changes (including changes from Piotr Kubaj): - Add license information [1, 2] - Add new sub-pixel hinting options [1, 2] - Regenerate patch [2] - Adapt pkg-plist [1] [1] - changes made by Piotr Kubaj. [2] - changes made by me. Also, I manually regenerated TIMESTAMP value for distinfo file with using following command: % make clean extract && find work/* -type f -print0 | xargs -0 stat -f '%m'= | sort -u | tail -1 based on "last modification time of the source" files, according to "SOURCE_DATE_EPOCH specification": https://reproducible-builds.org/specs/source-date-epoch/