From owner-freebsd-usb@FreeBSD.ORG Sat Jun 23 21:24:02 2007 Return-Path: X-Original-To: freebsd-usb@freebsd.org Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 634E616A41F; Sat, 23 Jun 2007 21:24:02 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe11.swip.net [212.247.155.65]) by mx1.freebsd.org (Postfix) with ESMTP id 4BE5513C457; Sat, 23 Jun 2007 21:24:00 +0000 (UTC) (envelope-from hselasky@c2i.net) X-Cloudmark-Score: 0.000000 [] Received: from [193.217.102.48] (account mc467741@c2i.net HELO [10.0.0.64]) by mailfe11.swip.net (CommuniGate Pro SMTP 5.1.9) with ESMTPA id 358244581; Sat, 23 Jun 2007 23:23:59 +0200 From: Hans Petter Selasky To: freebsd-current@freebsd.org Date: Sat, 23 Jun 2007 23:23:56 +0200 User-Agent: KMail/1.9.5 References: <1182632058.1217.3.camel@worf> In-Reply-To: <1182632058.1217.3.camel@worf> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200706232323.56543.hselasky@c2i.net> Cc: =?iso-8859-1?q?S=F8ren_Schmidt?= , current@freebsd.org, freebsd-usb@freebsd.org, Pascal Hofstee Subject: Re: recent USB changes break building of atausb module X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2007 21:24:02 -0000 On Saturday 23 June 2007 22:54, Pascal Hofstee wrote: > Hi, > > I just updated to a fresh current today to notice that with the recent > slew of commits to the usb subsystem, the atausb module no longer > compiles. I think this is because Warner Losh is doing some cleanup in the old USB stack. --HPS > > cc -O2 -fno-strict-aliasing -pipe -march=athlon-mp -D_KERNEL > -DKLD_MODULE -std=c99 -nostdinc -I. -I@ -I@/contrib/altq > -finline-limit=8000 --param inline-unit-growth=100 --param > large-function-growth=1000 -fno-common -mno-align-long-strings > -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 > -mno-sse3 -ffreestanding -Wall -Wredundant-decls -Wnested-externs > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline > -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions > -c /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c > /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:151: warning: > data definition has no type or storage class > /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:151: warning: > type defaults to 'int' in declaration of 'USB_DECLARE_DRIVER' > /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:151: warning: > parameter names (without types) in function declaration > /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:152: error: > 'atausb_driver' undeclared here (not in a function) > /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:152: error: > 'atausb_devclass' undeclared here (not in a function) > /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c: In function > 'atausb_attach': > /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:278: warning: > implicit declaration of function 'atausb_detach' > /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:278: warning: > nested extern declaration of 'atausb_detach' > /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c: At top > level: > /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:353: error: > static declaration of 'atausb_detach' follows non-static declaration > /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:278: error: > previous implicit declaration of 'atausb_detach' was here > *** Error code 1 > > I know it's not exactly critical as atausb is not built on default but > would appreciate it if somebody could have a closer look at this.