From owner-freebsd-stable@FreeBSD.ORG Wed Jul 7 02:44:06 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 122651065694; Wed, 7 Jul 2010 02:44:06 +0000 (UTC) (envelope-from doconnor@gsoft.com.au) Received: from cain.gsoft.com.au (cain.gsoft.com.au [203.31.81.10]) by mx1.freebsd.org (Postfix) with ESMTP id 896818FC0A; Wed, 7 Jul 2010 02:44:05 +0000 (UTC) Received: from ur.gsoft.com.au (Ur.gsoft.com.au [203.31.81.44]) (authenticated bits=0) by cain.gsoft.com.au (8.14.4/8.14.3) with ESMTP id o672gOSg091432 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 7 Jul 2010 12:13:53 +0930 (CST) (envelope-from doconnor@gsoft.com.au) Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=us-ascii From: "Daniel O'Connor" In-Reply-To: <20100707024217.GA77748@icarus.home.lan> Date: Wed, 7 Jul 2010 12:13:53 +0930 Content-Transfer-Encoding: quoted-printable Message-Id: <4BB8A521-E50D-4A0C-AEBA-6883BFD5846B@gsoft.com.au> References: <20100707024217.GA77748@icarus.home.lan> To: Jeremy Chadwick X-Mailer: Apple Mail (2.1081) X-Spam-Score: -2.51 () ALL_TRUSTED,BAYES_00,T_RP_MATCHES_RCVD X-Scanned-By: MIMEDefang 2.67 on 203.31.81.10 Cc: FreeBSD Stable , freebsd-ports@freebsd.org Subject: Re: MIMEDefang not starting on reboot X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2010 02:44:06 -0000 On 07/07/2010, at 12:12, Jeremy Chadwick wrote: >> --- /usr/local/etc/rc.d/mimedefang.sh-dist 2010-04-07 = 10:30:46.586067014 +0930 >> +++ /usr/local/etc/rc.d/mimedefang.sh 2010-05-01 13:47:47.340517685 = +0930 >> @@ -316,7 +319,7 @@ >> rm -f $MX_SOCKET > /dev/null 2>&1 >> rm -f $SOCKET > /dev/null 2>&1 >>=20 >> - if [ "$1" =3D "wait" ] ; then >> + if [ "wait" =3D "wait" ] ; then >> printf "Waiting for daemons to exit." >> WAITPID=3D"" >> test -f $PID && WAITPID=3D`cat $PID` >>=20 >> Otherwise restart is useless because it starts MD without waiting for = the old one to stop and it doesn't work :( >=20 > This should probably go to freebsd-ports not -stable, since both > mimedefang and perl are ports things. CC'ing. True. > Also, that patch doesn't look correct, or you got your diff arguments > backwards (e.g. change should be fixing the wait=3Dwait comparison to > use $1=3Dwait). No, really, I want it to always succeed. The optional wait appears to be a Linux thing, however rc.d scripts on = FreeBSD [should] always wait for their daemons to exit, otherwise = restart will try and start it before it has exited. -- Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C