From owner-cvs-all@FreeBSD.ORG Sun Jul 18 19:19:06 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A08A416A4CE; Sun, 18 Jul 2004 19:19:06 +0000 (GMT) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id 62BCD43D41; Sun, 18 Jul 2004 19:19:05 +0000 (GMT) (envelope-from dwmalone@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 18 Jul 2004 20:19:04 +0100 (BST) To: Sam Leffler In-reply-to: Your message of "Sun, 18 Jul 2004 09:51:06 PDT." <200407180951.06333.sam@errno.com> X-Request-Do: Date: Sun, 18 Jul 2004 20:19:03 +0100 From: David Malone Message-ID: <200407182019.aa26012@salmon.maths.tcd.ie> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_socket.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jul 2004 19:19:06 -0000 > > I missed two pieces of the commit to this file. Robert has already > > added one, this adds the other. > Not to pick on this commit, but recently there have been several commits where > the log msg addressed _why_ the commit was done but never described _what_ > was changed. Since the rational for the commit had been described in the commit message that I'd intended to make the commit in, I wasn't really sure what useful I could say. The change was to replace f(blah) with f(&blah), where blah was a pointer. Admittedly, in the original commit message, I probably could have explained the changes in more detail. > This is not helpful; someone coming along later with only CVS > for reference must do a diff to even guess what the change does. Good commit > msgs give a reader an understanding of the reason and content of a change. Ian Dowse has written a great tool (rcshist) for looking at RCS/CVS files and getting the diffs inline. I often use it when trying to diagnose problems or understand bits of code. The source is at: http://www.maths.tcd.ie/~iedowse/FreeBSD/rcshist-1.02.tgz Mind you, that doesn't give me an excuse to write bad commit messages ;-) David.