From owner-freebsd-gecko@FreeBSD.ORG  Fri Sep 17 04:21:17 2010
Return-Path: <owner-freebsd-gecko@FreeBSD.ORG>
Delivered-To: freebsd-gecko@freebsd.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 3D1A4106564A;
	Fri, 17 Sep 2010 04:21:16 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Beat Gaetzi <beat@freebsd.org>
Date: Fri, 17 Sep 2010 00:21:05 -0400
User-Agent: KMail/1.6.2
References: <201009091828.12400.jkim@FreeBSD.org>
	<4C89E15C.7020608@FreeBSD.org>
In-Reply-To: <4C89E15C.7020608@FreeBSD.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_0yukMI0WRYhyA+Y"
Message-Id: <201009170021.08900.jkim@FreeBSD.org>
Cc: freebsd-gecko@freebsd.org
Subject: Re: Fwd: IcedTea6 Mozilla plugin with OpenJDK6
X-BeenThere: freebsd-gecko@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Gecko Rendering Engine issues <freebsd-gecko.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gecko>,
	<mailto:freebsd-gecko-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gecko>
List-Post: <mailto:freebsd-gecko@freebsd.org>
List-Help: <mailto:freebsd-gecko-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gecko>,
	<mailto:freebsd-gecko-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Sep 2010 04:21:17 -0000


--Boundary-00=_0yukMI0WRYhyA+Y
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Friday 10 September 2010 03:42 am, Beat Gaetzi wrote:
> On 10.09.2010 00:28, Jung-uk Kim wrote:
> > While I was porting a Mozilla plugin, I found something
> > disturbing:
> >
> > %pkg-config --modversion mozilla-plugin
> > 1.9.2.8
> > %pkg-config --cflags mozilla-plugin
> > -DXP_UNIX -I/usr/local/include/libxul/stable
> > %ls -dl /usr/local/include/libxul/stable/
> > ls: /usr/local/include/libxul/stable/: No such file or directory
> > %pkg_info -W /usr/local/libdata/pkgconfig/mozilla-plugin.pc
> > /usr/local/libdata/pkgconfig/mozilla-plugin.pc was installed by
> > package libxul-1.9.2.8 %pkg-config --cflags libxul
> > -fshort-wchar -I/usr/local/include/libxul
> > -I/usr/local/include/nspr %ls -dl /usr/local/include/libxul/
> > drwxr-xr-x  11 root  wheel  56832 Aug  9 16:21
> > /usr/local/include/libxul/
> >
> > As you can see, --cflags returns a nonexistent directory for
> > mozilla-plugin package.  It returns the correct directory for
> > libxul, though.  As a workaround, I had to do this:
> >
> > # XXX Need to fix in ports.
> > CFLAGS+=	${PLUGIN_CFLAGS:C/\/libxul\/stable/\/libxul/}
> >
> > Can anyone explain what's going on here?
>
> The stable and unstable include directories no longer exists with
> libxul 1.9.2. I don't know why the stable directory is still listed
> in the mozilla-plugin.pc file. Should we add this substitution to
> the libxul port?

Please see the attached patch.  It seems this is the only file that 
references include/libxul/stable now.

Thanks,

Jung-uk Kim

--Boundary-00=_0yukMI0WRYhyA+Y
Content-Type: text/plain; charset="iso-8859-1";
	name="patch-xulrunner_installer_mozilla-plugin.pc.in"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="patch-xulrunner_installer_mozilla-plugin.pc.in"

--- xulrunner/installer/mozilla-plugin.pc.in.orig	2010-08-24 18:19:38.000000000 -0400
+++ xulrunner/installer/mozilla-plugin.pc.in	2010-09-16 22:02:35.000000000 -0400
@@ -5,5 +5,4 @@
 Name: Mozilla Plug-In API
 Description: Mozilla Plug-In API
 Version: %MOZILLA_VERSION%
-Cflags: -I${includedir}/stable -DXP_UNIX %ojidef%
-
+Cflags: -I${includedir} -DXP_UNIX %ojidef%

--Boundary-00=_0yukMI0WRYhyA+Y--