From owner-freebsd-ipfw Wed Jul 28 13:46:58 1999 Delivered-To: freebsd-ipfw@freebsd.org Received: from janus.syracuse.net (janus.syracuse.net [205.232.47.15]) by hub.freebsd.org (Postfix) with ESMTP id 1DEBA14C56; Wed, 28 Jul 1999 13:46:54 -0700 (PDT) (envelope-from green@FreeBSD.org) Received: from localhost (green@localhost) by janus.syracuse.net (8.9.2/8.8.7) with ESMTP id QAA94554; Wed, 28 Jul 1999 16:46:22 -0400 (EDT) X-Authentication-Warning: janus.syracuse.net: green owned process doing -bs Date: Wed, 28 Jul 1999 16:46:21 -0400 (EDT) From: "Brian F. Feldman" X-Sender: green@janus.syracuse.net To: Nate Williams Cc: Alfred Perlstein , hackers@FreeBSD.org, freebsd-ipfw@FreeBSD.org, bde@FreeBSD.org Subject: Re: securelevel and ipfw zero In-Reply-To: <199907282040.OAA03306@mt.sri.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-ipfw@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 28 Jul 1999, Nate Williams wrote: > > > > *rant on* > > > > Brian, FreeBSD isn't your private playground for playing around, this is > > > > a group project, and you gotta follow the rules, or you don't get to > > > > play with the rest of the folks.... > > > > > > The rules don't say "leave the code that you work with in a bigger mess than > > > when you started." Cleaning up code is a fact of life, and it _NEEDS_ to be > > > done to get work done, very often. You have to learn to deal with that. > > > > > > > *rant off* > > > > and so it should remain, changes that provide readability to > > code should be committed, the only time documentation of code > > is wrong is when it it is incorrect. > > The changes pointed out do *NOT* make the code more readable. They just > move statements around for no reason, and change whitespace. It makes it more readable if you understand and use KNF instead of try to bastardize everyone else's code. > > > Increasing the size of the cvs repo is not a consideration when > > worthwhile docs can be incorperated, especially when the person > > who needs to maintain it requires changess for readability. > > Brian is *NOT* the maintainer, he is the author of a patch to it. I'm one of the people who actively works on it. Who are you? > > Doesn't anyone care for keeping the source code consistant *AND* > maintainable for multiple people, as well as maintaining a history of > *CHANGES* for people to review in the future? What do you think KNF is about? I'll bring out the big guns now (BDE). > > Or is this Linux, where we don't give a rip and whatever the current > patch does to the rest of the tree is fine, since the more code we have > the better? > You have no idea what you're talking about, WRT FreeBSD. > > > Nate > Brian Fundakowski Feldman _ __ ___ ____ ___ ___ ___ green@FreeBSD.org _ __ ___ | _ ) __| \ FreeBSD: The Power to Serve! _ __ | _ \._ \ |) | http://www.FreeBSD.org/ _ |___/___/___/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ipfw" in the body of the message