From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Mar 15 17:30:01 2008
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CF4841065670
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat, 15 Mar 2008 17:30:01 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id BF2BD8FC13
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat, 15 Mar 2008 17:30:01 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m2FHU1d3055265
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Sat, 15 Mar 2008 17:30:01 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m2FHU1ep055264;
	Sat, 15 Mar 2008 17:30:01 GMT (envelope-from gnats)
Resent-Date: Sat, 15 Mar 2008 17:30:01 GMT
Resent-Message-Id: <200803151730.m2FHU1ep055264@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Max Khon <fjoe@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4C865106566C
	for <freebsd-gnats-submit@hub.freebsd.org>;
	Sat, 15 Mar 2008 17:20:12 +0000 (UTC)
	(envelope-from fjoe@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 4EB658FC19
	for <freebsd-gnats-submit@hub.freebsd.org>;
	Sat, 15 Mar 2008 17:20:12 +0000 (UTC)
	(envelope-from fjoe@FreeBSD.org)
Received: from freefall.freebsd.org (fjoe@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m2FHKBtI055132
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Mar 2008 17:20:11 GMT
	(envelope-from fjoe@freefall.freebsd.org)
Received: (from fjoe@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m2FHKBnf055131;
	Sat, 15 Mar 2008 17:20:11 GMT (envelope-from fjoe)
Message-Id: <200803151720.m2FHKBnf055131@freefall.freebsd.org>
Date: Sat, 15 Mar 2008 17:20:11 GMT
From: Max Khon <fjoe@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Cc: 
Subject: ports/121741: LIB_DEPENDS does not work for libraries with '+' in a
	name
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Max Khon <fjoe@FreeBSD.org>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Mar 2008 17:30:01 -0000


>Number:         121741
>Category:       ports
>Synopsis:       LIB_DEPENDS does not work for libraries with '+' in a name
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 15 17:30:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Max Khon
>Release:        FreeBSD 7.0-STABLE i386
>Organization:
FreeBSD.org
>Environment:

>Description:

LIB_DEPENDS does not work if library name contains '+'

>How-To-Repeat:

Replace BUILD_DEPENDS/RUN_DEPENDS in audio/esperanza with
appropriate LIB_DEPENDS: the depend does not work -- the xmmsclient++.1 library
can not be found during build.

>Fix:

Index: Mk/bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.591
diff -u -p -r1.591 bsd.port.mk
--- Mk/bsd.port.mk	11 Mar 2008 23:45:04 -0000	1.591
+++ Mk/bsd.port.mk	15 Mar 2008 17:15:56 -0000
@@ -4872,11 +4872,7 @@ lib-depends:
 .if defined(LIB_DEPENDS) && !defined(NO_DEPENDS)
 	@for i in ${LIB_DEPENDS}; do \
 		lib=$${i%%:*}; \
-		case $$lib in \
-			*.*.*)	pattern="`${ECHO_CMD} $$lib | ${SED} -e 's/\./\\\\./g'`" ;;\
-			*.*)	pattern="$${lib%%.*}\.$${lib#*.}" ;;\
-			*)	pattern="$$lib" ;;\
-		esac; \
+		pattern="`${ECHO_CMD} $$lib | ${SED} -e 's/\./\\\\./g' -e 's/+/\\\\+/g'`"\
 		dir=$${i#*:}; \
 		target=$${i##*:}; \
 		if ${TEST} $$dir = $$target; then \


>Release-Note:
>Audit-Trail:
>Unformatted: