From owner-svn-src-all@FreeBSD.ORG Wed Feb 19 13:01:24 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DD3FCCD6; Wed, 19 Feb 2014 13:01:24 +0000 (UTC) Received: from mail.vx.sk (mail.vx.sk [IPv6:2a01:4f8:150:6101::4]) by mx1.freebsd.org (Postfix) with ESMTP id 859D914B3; Wed, 19 Feb 2014 13:01:24 +0000 (UTC) Received: from mail.vx.sk (localhost [127.0.0.1]) by mail.vx.sk (Postfix) with ESMTP id B543CDD25; Wed, 19 Feb 2014 14:01:23 +0100 (CET) X-Virus-Scanned: amavisd-new at mail.vx.sk Received: from mail.vx.sk by mail.vx.sk (amavisd-new, unix socket) with LMTP id SRo5SYNWmO9R; Wed, 19 Feb 2014 14:01:23 +0100 (CET) Received: from mail.vx.sk (localhost [IPv6:::1]) by mail.vx.sk (Postfix) with ESMTPSA id 2662DDD13; Wed, 19 Feb 2014 14:01:23 +0100 (CET) Received: from 10.0.0.18 ([10.0.0.18]) by mail.vx.sk (Horde Framework) with HTTP; Wed, 19 Feb 2014 14:01:23 +0100 Date: Wed, 19 Feb 2014 14:01:23 +0100 Message-ID: <20140219140123.Horde.zrXx5GqkiiaAfGIetc98KQ1@mail.vx.sk> From: Martin Matuska To: Gleb Smirnoff Subject: Re: svn commit: r262196 - head/sys/netpfil/pf References: <201402182217.s1IMHCeM077356@svn.freebsd.org> <20140219101736.GX63039@glebius.int.ru> In-Reply-To: <20140219101736.GX63039@glebius.int.ru> User-Agent: Internet Messaging Program (IMP) H5 (6.1.6) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Description: =?utf-8?b?U3Byw6F2YQ==?= s =?utf-8?b?xI1pc3TDvW0=?= textom X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Nikos Vassiliadis , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Feb 2014 13:01:24 -0000 Hi Gleb, I understand your point - if anything is broken (or more broken than before) I can revert this patch anytime. FreeNAS and other folks may fork separate branches and we can wait until about FreeBSD 12.0 for the patch being reviewed so we can commit it around 14.0 - maybe we have switched to a completely different firewall at that time and this issue becomes obsolete anyway. Best regards, mm Quoting Gleb Smirnoff : > Martin, > > On Tue, Feb 18, 2014 at 10:17:12PM +0000, Martin Matuska wrote: > M> Author: mm > M> Date: Tue Feb 18 22:17:12 2014 > M> New Revision: 262196 > M> URL: http://svnweb.freebsd.org/changeset/base/262196 > M> > M> Log: > M>   De-virtualize pf_mtag_z [1] > M>   Process V_pf_overloadqueue in vnet context [2] > M> > M>   This fixes two VIMAGE kernel panics and allows to simultaneously > run host-pf > M>   and vnet jails. pf inside jails remains broken. > M> > M>   PR:                kern/182964 > M>   Submitted by:        glebius@FreeBSD.org [2], myself [1] > M>   Tested by:        rodrigc@FreeBSD.org, myself > M>   MFC after:        2 weeks > > I've sent your patch to Nikos, who is working on pf+vimage. He > also accumulates his work on pf+vimage in projects/pf branch, > planning to do it properly and then merge to head in one go. > I was waiting for his review. Yes, he is slow with reviews, > but that's not a reason to commit w/o review. > > --Totus tuus, Glebius. -- Martin Matuska FreeBSD committer http://blog.vx.sk