From owner-svn-src-all@FreeBSD.ORG Sat Jun 29 16:19:22 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D8BD6FC1; Sat, 29 Jun 2013 16:19:22 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 67AD31C2D; Sat, 29 Jun 2013 16:19:22 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r5TGJEjc062928; Sat, 29 Jun 2013 19:19:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r5TGJEjc062928 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r5TGJEfv062927; Sat, 29 Jun 2013 19:19:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 29 Jun 2013 19:19:14 +0300 From: Konstantin Belousov To: Tim Kientzle Subject: Re: svn commit: r252376 - head/lib/libutil Message-ID: <20130629161914.GD91021@kib.kiev.ua> References: <201306291552.r5TFqnLV022460@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1l9qxdz78y/2tmkl" Content-Disposition: inline In-Reply-To: <201306291552.r5TFqnLV022460@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,FREEMAIL_REPLY,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jun 2013 16:19:22 -0000 --1l9qxdz78y/2tmkl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 29, 2013 at 03:52:49PM +0000, Tim Kientzle wrote: > Author: kientzle > Date: Sat Jun 29 15:52:48 2013 > New Revision: 252376 > URL: http://svnweb.freebsd.org/changeset/base/252376 >=20 > Log: > Fix -Wunsequenced warning What is this ? From the name of the warning, it sounds as if the problem is in the lack of sequence point between two modifications of the same variable in the expression ? But, there function' argument evaluation and function call are separated by seq point, AFAIR. Could you, please, clarify ? [Not that I think that the changes are bad] > =20 > Submitted by: dt71@gmx.com >=20 > Modified: > head/lib/libutil/login_times.c >=20 > Modified: head/lib/libutil/login_times.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libutil/login_times.c Sat Jun 29 15:51:27 2013 (r252375) > +++ head/lib/libutil/login_times.c Sat Jun 29 15:52:48 2013 (r252376) > @@ -96,7 +96,7 @@ parse_lt(const char *str) > else > m.lt_start =3D 0; > if (*p =3D=3D '-') > - p =3D parse_time(++p, &m.lt_end); > + p =3D parse_time(p + 1, &m.lt_end); > else > m.lt_end =3D 1440; > =20 --1l9qxdz78y/2tmkl Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQIcBAEBAgAGBQJRzwkBAAoJEJDCuSvBvK1BQ14P/12Cu91+LHgAxc5bH9AiB6XW XqWqH630D+2ok9YxJs3dd7bqNEskM+BxC4PpQpQHn8It5MP1w5IfBWGxkhBZkQC0 uhQfmgQ6w8BZUMd0qFNg0Yx1lvyM2k1bjDuvEh2a7irLkKsgtRSIKSLsBBJu7yjC Q8XuBAjiAxIoTNCLL4T6G7iJb4ST3WnQ7DyGbNvxClDGPC3JMXGK41kt5QemcHio FfVRr+wbn22ipjuDuTLM8sA40QHGeN1XM6EkafcDT/3P8yNWlhKhBpIr5u76erz4 cTn6Q0EjThbLUO/6+F6rwFisgXbF0w9CTtFYm1ZF0nEAR4jWeXTejmllPX21I9u+ z6pu++oW/c9U25EKu+aPtvmwwSAbH8ZNROlJzXewFLr8zMbYoXERnJYP4alvqcOj 3kAsOzhHVt9rfn53VIl9kuXABGhhQ2U+q7eCYffiZp9ukM7L7AKPCNaLtAzS/22q ROR7Lq62DwqEgk4iQUHLu0pjY4qBc8iXxTSF6pEpcQzMwsBw+dd3U8Bsg5LWD+Eh RKpD+skjMRqzrnc3kGqWRdSgNVaJIt4M8gR2WwyYwTZKfhMi+3I4U1LG5QeW64nN s6V+B8s9jF9ZQXupzTyqjxg6zBP5lRYjPQBP4YDFRMK9KXcfNvPOSeCeVDHD4sP3 f8DnNyXSC7DNYzWwpOxJ =lPA8 -----END PGP SIGNATURE----- --1l9qxdz78y/2tmkl--