From owner-freebsd-hackers@FreeBSD.ORG Thu Sep 18 09:15:15 2008 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 226C41065670; Thu, 18 Sep 2008 09:15:15 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id C14818FC0C; Thu, 18 Sep 2008 09:15:14 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) DomainKey-Signature: a=rsa-sha1; q=dns; c=simple; s=one; d=codelabs.ru; h=Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To:Sender; b=gdiG8yWqrsfHUqukkb/+Q9L3D4gk9kC+uN54HciEsua9x1o7uIDhb0nU4pDbSb3IvFezuGTy6FSedcQstgjyTTTJLoUKzFilJHVDaXEjPyLSYIcOt94UVsPzyIDDjl4p9pou6cWogh9zYXF/pNi7bV7Es7mfksxGTrdxVYE5KRM=; Received: from void.codelabs.ru (void.codelabs.ru [144.206.177.25]) by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1KgFbT-0008a7-Sw; Thu, 18 Sep 2008 13:15:12 +0400 Date: Thu, 18 Sep 2008 13:15:10 +0400 From: Eygene Ryabinkin To: Maksim Yevmenkin Message-ID: References: <20080917161633.9E2F717101@shadow.codelabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Osvg0bgWkLaeQPMj" Content-Disposition: inline In-Reply-To: Sender: rea-fbsd@codelabs.ru Cc: rik@freebsd.org, hackers@freebsd.org, bug-followup@freebsd.org Subject: Re: kern/127446: [patch] fix race in sys/dev/kbdmux/kbdmux.c X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2008 09:15:15 -0000 --Osvg0bgWkLaeQPMj Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Me again. Thu, Sep 18, 2008 at 11:10:17AM +0400, Eygene Ryabinkin wrote: > OK, I had tried substituting KBDMUX_LOCK/UNLOCK with Giant operations -- > it works as expected. Tried my initial patch on some 7.0-PRERELEASE -- it locks keyboard when geli asks for the password. Had not much time to dig it out, will try to do it as soon as I can. Substituting KBDMUX_LOCK/UNLOCK with Giant locking helps even on this FreeBSD version. More testing needed, may be there are some other issues that aren't revealing themselves... --=20 Eygene _ ___ _.--. # \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard / ' ` , __.--' # to read the on-line manual =20 )/' _/ \ `-_, / # while single-stepping the kernel. `-'" `"\_ ,_.-;_.-\_ ', fsc/as # _.-'_./ {_.' ; / # -- FreeBSD Developers handbook=20 {_.-``-' {_/ # --Osvg0bgWkLaeQPMj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkjSHB4ACgkQthUKNsbL7YioXQCdFW6oiOEMnP3H1H7GottuoSVM 4xEAoJszdX8jUpmfbXxXd9Yy2Bms7K39 =Qchb -----END PGP SIGNATURE----- --Osvg0bgWkLaeQPMj--