From owner-cvs-all Thu Feb 6 15:46:35 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EAEF437B401; Thu, 6 Feb 2003 15:46:32 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DF7C43FBD; Thu, 6 Feb 2003 15:46:32 -0800 (PST) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h16NkWbv088538; Thu, 6 Feb 2003 15:46:32 -0800 (PST) (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h16NkWQu088537; Thu, 6 Feb 2003 15:46:32 -0800 (PST) Message-Id: <200302062346.h16NkWQu088537@repoman.freebsd.org> From: Scott Long Date: Thu, 6 Feb 2003 15:46:32 -0800 (PST) To: all-committers@FreeBSD.org, legacy-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/mly mly.c mlyvar.h X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG scottl 2003/02/06 15:46:32 PST Modified files: sys/dev/mly mly.c mlyvar.h Log: Fix the mly driver! If card resources became unavailable, the driver would correctly tell CAM to requeue the command and then freeze it's queue. The problem was that when resources became available again, it wouldn't tell CAM to unfreeze it's queue, so no more commands would ever be delivered. This is simialr to the bug that was fixed in the cciss driver last year. This is a bug in 4-STABLE also, but is probably masked by the OS being fast enough to drain the completion queue before it fills up. Also add some diagnostics avaialble when compiled with MLY_DEBUG. Thanks very much to LSI Corp for donating equipment to track this down, and Vaidus Damosevicius for pestering me long enough to get it fixed. Revision Changes Path 1.20 +46 -0 src/sys/dev/mly/mly.c 1.5 +2 -0 src/sys/dev/mly/mlyvar.h To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message