From owner-cvs-src@FreeBSD.ORG Sun Apr 6 13:48:58 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B8E11065671 for ; Sun, 6 Apr 2008 13:48:58 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from QMTA06.westchester.pa.mail.comcast.net (qmta06.westchester.pa.mail.comcast.net [76.96.62.56]) by mx1.freebsd.org (Postfix) with ESMTP id 2DCA78FC31 for ; Sun, 6 Apr 2008 13:48:58 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from OMTA08.westchester.pa.mail.comcast.net ([76.96.62.12]) by QMTA06.westchester.pa.mail.comcast.net with comcast id AAUq1Z00A0Fqzac560LD00; Sun, 06 Apr 2008 13:47:41 +0000 Received: from discordia ([24.60.135.75]) by OMTA08.westchester.pa.mail.comcast.net with comcast id ADox1Z0011dmTCQ3U00000; Sun, 06 Apr 2008 13:48:57 +0000 X-Authority-Analysis: v=1.0 c=1 a=wfyTI2jGULUA:10 a=UcQdyvHyK3wA:10 a=c5sTgUsrrxMA:10 a=Wj8HP1ZwoTE8aXALNcIA:9 a=Oibl90ofgS6SbfjdDX4A:7 a=y_axJBUsizMAhhHZtlirfk4N6-gA:4 a=SKpDKCWXRSQA:10 Received: by discordia (Postfix, from userid 103) id 0393B1636F9; Sun, 6 Apr 2008 09:48:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.20.1.3] (erwin.int.cokane.org [172.20.1.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by discordia (Postfix) with ESMTP id 3B74F1636F8; Sun, 6 Apr 2008 09:48:43 -0400 (EDT) Message-ID: <47F8D4BD.1020901@FreeBSD.org> Date: Sun, 06 Apr 2008 09:48:45 -0400 From: Coleman Kane Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.12 (X11/20080312) MIME-Version: 1.0 To: Greg 'groggy' Lehey References: <200804040357.m343vlQ8083007@repoman.freebsd.org> <20080405193851.J66744@maildrop.int.zabbadoz.net> <20080405234758.GB27705@dereel.lemis.com> <47F81C48.1040103@FreeBSD.org> <20080406053648.GC27705@dereel.lemis.com> In-Reply-To: <20080406053648.GC27705@dereel.lemis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, "Bjoern A. Zeeb" , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/bin/ls ls.1 ls.c ls.h print.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: cokane@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Apr 2008 13:48:58 -0000 Greg 'groggy' Lehey wrote: > On Saturday, 5 April 2008 at 20:41:44 -0400, Coleman Kane wrote: > >> Greg 'groggy' Lehey wrote: >> >>> On Saturday, 5 April 2008 at 19:40:02 +0000, Bjoern A. Zeeb wrote: >>> >>> >>>> On Fri, 4 Apr 2008, Greg Lehey wrote: >>>> >>>> >>>> >>>>> grog 2008-04-04 03:57:47 UTC >>>>> >>>>> FreeBSD src repository >>>>> >>>>> Modified files: >>>>> bin/ls ls.1 ls.c ls.h print.c >>>>> Log: >>>>> Add -D option to specify exact format of date and time output with ls -l. >>>>> >>>>> >>>> I think something went wrong here. Could you please fix this. Thanks. >>>> >>>> bz@dopt:/local/building/freebsd/HEAD/bin/ls> ll >>>> total 80 >>>> drwxr-xr-x 2 bz wheel 512 Apr 5 15:18 CVS/ >>>> -rw-r--r-- 1 bz wheel 300 May 25 2004 Makefile >>>> -rw-r--r-- 1 bz wheel 4803 Mar 24 2006 cmp.c >>>> -rw-r--r-- 1 bz wheel 2852 Mar 24 2006 extern.h >>>> >>>> >>> Ugh. My editor was a little too zealous in replacing spaces with tabs :-( >>> >> Uhm.... shouldn't this be "\t" instead of the actualy tab character >> (0x08)? >> > > No. It should be two spaces. > > Here's the diff :-) > > --- print.c 4 Apr 2008 03:57:46 -0000 1.77 > +++ print.c 5 Apr 2008 23:44:24 -0000 > @@ -388,7 +388,7 @@ > format = d_first ? "%e %b %R" : "%b %e %R"; > else > /* mmm dd yyyy || dd mmm yyyy */ > - format = d_first ? "%e %b %Y" : "%b %e %Y"; > + format = d_first ? "%e %b %Y" : "%b %e %Y"; > strftime(longstring, sizeof(longstring), format, localtime(&ftime)); > > For reasons lost in the mists of time, there are two spaces before the > %Y in this format, but my editor accidentally replaced them with a tab > character. As you can see, that's not immediately obvious. > > Greg > -- > See complete headers for address and phone numbers. > Oh heh. I had a dyslexic moment there (I read "tabs with spaces"). Nevermind. -- Coleman